969587 - Make single variant customization run even when no ICCHelper is available

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Description

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Currently, if ICCHelper is not available (for instance, on B2G Desktop), the customization step is skipped. Instead, we should continue with customization, using a 000-000 mnc/mcc pair.

Comment 1

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Attachment: Patch 1 (v1) - Run variant customization in FTU even without ICC

This also contains the beginning of integration tests for variant customization checking. Pretty scant at the moment.

Comment 2

[Aus Lacroix [:aus]]

Comment on attachment 8372703 [details] [review]
Patch 1 (v1) - Run variant customization in FTU even without ICC

Looks good to me. One minor nit noted in github and the linter is complaining so let's fix that before checking in. :)

Comment 3

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8372703 [details] [review]
Patch 1 (v1) - Run variant customization in FTU even without ICC

Thanks a lot for the better test library.

Looking good to me, please merge once travis is green (missing some stuff in ftu_upgrade_tests.js)

Cheers!
F.

Comment 4

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

https://github.com/mozilla-b2g/gaia/pull/16097

Comment 5

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

https://github.com/mozilla-b2g/gaia/commit/3999923d41b5f21871f92d48ff7e9248d05d9ef1

Comment 6

[Kevin Grandon :kgrandon]

Had to back this out due to too many intermittent failures (10 or 20%): https://github.com/mozilla-b2g/gaia/commit/757ad3e60cb44ca5b2001144bfdd59afbc57f2af

Taking another look it appears that just the integration test was backed out?

Comment 7

[Kevin Grandon :kgrandon]

Dump of the intermittent error stack:

1) First Time Use > Single Variant Customization > FTU runs customization when no ICCHelper available:

ElementNotVisible: (11) Element is not visible

Remote Stack:

<none>

at Error.MarionetteError (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/error.js:67:13)

at Object.Client._handleCallback (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:474:19)

at /home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:508:21

at TcpSync.send (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/drivers/tcp-sync.js:94:10)

at Object.send (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:455:36)

at Object.Client._sendCommand (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:501:19)

at Object.Element._sendCommand (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/element.js:49:21)

at Object.click (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/element.js:172:19)

at Context.<anonymous> (/home/travis/build/mozilla-b2g/gaia/apps/communications/ftu/test/marionette/variant_test.js:28:42)

at Test.Runnable.run (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runnable.js:211:32)

at Runner.runTest (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:372:10)

at /home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:448:12

at next (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:297:14)

at /home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:307:7

at next (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:245:23)

at /home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:269:7

at done (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runnable.js:185:5)

at /home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runnable.js:197:9

at Object.executeHook (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:370:18)

at process._tickCallback (node.js:415:13)

Comment 8

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Oops. Had click events on elements that require other clicks to get to, without waitForElement calls in between. Should be an easy fix.

Comment 9

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Ok. Wow. This test is wrong in multiple ways anyways. It tests whether /browser/ ran its db updates, not the FTU. So it'll need to be rewritten anyways. The problem being that we're also moving bookmark creation to FTU, and now those will be created in the system datastore, so we'll need to make sure that lands first before landing this so the test will actually work. Blocking it on bug 940647.

Comment 10

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

And out a sprint this goes, as it's now going to have to follow moving bookmark loading into the system datastore (bug 940647)

Comment 11

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Hit a chicken and egg problem. I need this to be able to test bug 940647, but the integration test will need to be updated /in/ bug 940647. So I'm going to yank the integration test commit on this, land the feature, and fix the test in bug 940647.

Comment 12

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Ok, only the integration tests got backed out, so running the ICC helper is actually in and done. Remarking resolved, and will add integration tests in bug 940647.