969632 - glDeleteFoo funcs should take `const GLint*` not `GLint*`

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Kelsey Gilbert [:jgilbert]]

For some reason, our GLContext::fDeleteTextures and friends take `GLint*` instead of `const GLint*`, meaning that you'll see code like this in places:
class {
  GLContext* const mGL;
  const GLint mTex;

  void Foo() {
    GLint tex = mTex;
    mGL->fDeleteTextures(1, &tex);
    // OR
    mGL->fDeleteTextures(1, (GLint*)&tex);
    // Instead of
    mGL->fDeleteTextures(1, &tex); // "Can't convert `const GLint*` to `GLint*` without loosing qualifiers"
  }
};

Interestingly, GLContextSymbols has is already const-correct.

Comment 1

[Kelsey Gilbert [:jgilbert]]

Attachment: patch

Comment 2

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6d7069935a34

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/6d7069935a34

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

(In reply to Jeff Gilbert [:jgilbert] from comment #0)
> For some reason, our GLContext::fDeleteTextures and friends take `GLint*`
> instead of `const GLint*`, meaning that you'll see code like this in places: ...

I don't see you removing those workarounds. How come?

Comment 5

[Kelsey Gilbert [:jgilbert]]

(In reply to :Ms2ger from comment #4)
> (In reply to Jeff Gilbert [:jgilbert] from comment #0)
> > For some reason, our GLContext::fDeleteTextures and friends take `GLint*`
> > instead of `const GLint*`, meaning that you'll see code like this in places: ...
> 
> I don't see you removing those workarounds. How come?

I didn't think to include that in this bug, for some reason. Thanks. Reopening to do this.

Comment 6

[Kelsey Gilbert [:jgilbert]]

Attachment: patch 2

Comment 7

[Kelsey Gilbert [:jgilbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b135788f78ea

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b135788f78ea