969650 - Move gaia customization sample into gaia repo

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Right now the gaia customization sample is in an external repo, not managed by mozilla-b2g org on github. Since it doesn't change much, isn't huge, and would be nice to have around for integration tests, we should move it into gaia proper.

Comment 1

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Attachment: Patch 1 (v1) - Move customization sample to gaia

Moving customization sample to gaia/customization. r?'ing yuren 'cause it's his repo, peter because this affects vendors, vivien because this is a root level addition to gaia and I'm not sure if this is cool or we want something similar to a contrib/ so we keep root clean.

Comment 2

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8372626 [details] [review]
Patch 1 (v1) - Move customization sample to gaia

Hi Kyle, thanks for your pull request!

please check the comments on github and we should use another background because I capture those images from my mac and it would be great if we can use a background which is licensed by MPL or Creative Common.

set review falg to me if you get updated pull request.

Comment 3

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 8372626 [details] [review]
Patch 1 (v1) - Move customization sample to gaia

In order to keep blame consistency, I changed this to a subtree merge then made a commit with my cleanup changes on top of it. Once I get a background from UX I'll resubmit for review.

Comment 4

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Attachment: Patch 1 (v2) - Move customization sample to gaia

Made recommended changes, changed default wallpaper picture to be FxOS logo.

Comment 5

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8373751 [details] [review]
Patch 1 (v2) - Move customization sample to gaia

r=yurenju if customization/power/carrier_power_on.png is replaced to firefox os background :-)

Comment 6

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Done, thanks! Just pushed a new version, will merge tomorrow after it goes through another travis run and after I have a chance to update the wiki documentation and product team :)

Comment 7

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

https://github.com/mozilla-b2g/gaia/commit/a84300a30dd61be065e394c810e6fa350283839a

Talked to product, going to update wiki and email dev-gaia and ffos-tam about the move. Will close this bug after that, which will mean yuren and also remove his repo.

Comment 8

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Wiki updated:

https://developer.mozilla.org/en-US/Firefox_OS/Hacking_Firefox_OS/Market_customizations_guide

Comment 9

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

And email sent

https://groups.google.com/forum/#!topic/mozilla.dev.gaia/-hWSOTqJ4z4

Closing out.