Closed Bug 969650 Opened 7 years ago Closed 7 years ago

Move gaia customization sample into gaia repo

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
1.4 S1 (14feb)

People

(Reporter: qdot, Assigned: qdot)

References

Details

(Whiteboard: [systemsfe] [1.4:p2] [p=3] [1.4 SP 1 (14feb)])

Attachments

(1 file, 1 obsolete file)

Right now the gaia customization sample is in an external repo, not managed by mozilla-b2g org on github. Since it doesn't change much, isn't huge, and would be nice to have around for integration tests, we should move it into gaia proper.
Moving customization sample to gaia/customization. r?'ing yuren 'cause it's his repo, peter because this affects vendors, vivien because this is a root level addition to gaia and I'm not sure if this is cool or we want something similar to a contrib/ so we keep root clean.
Attachment #8372626 - Flags: review?(yurenju.mozilla)
Attachment #8372626 - Flags: review?(pdolanjski)
Attachment #8372626 - Flags: review?(21)
Comment on attachment 8372626 [details] [review]
Patch 1 (v1) - Move customization sample to gaia

Hi Kyle, thanks for your pull request!

please check the comments on github and we should use another background because I capture those images from my mac and it would be great if we can use a background which is licensed by MPL or Creative Common.

set review falg to me if you get updated pull request.
Attachment #8372626 - Flags: review?(yurenju.mozilla)
Whiteboard: [systemsfe] [1.4:p2] [p=3] [1.4 SP 1 (14feb)]
Comment on attachment 8372626 [details] [review]
Patch 1 (v1) - Move customization sample to gaia

In order to keep blame consistency, I changed this to a subtree merge then made a commit with my cleanup changes on top of it. Once I get a background from UX I'll resubmit for review.
Attachment #8372626 - Flags: review?(pdolanjski)
Attachment #8372626 - Flags: review?(21)
Made recommended changes, changed default wallpaper picture to be FxOS logo.
Attachment #8372626 - Attachment is obsolete: true
Attachment #8373751 - Flags: review?(yurenju.mozilla)
Comment on attachment 8373751 [details] [review]
Patch 1 (v2) - Move customization sample to gaia

r=yurenju if customization/power/carrier_power_on.png is replaced to firefox os background :-)
Attachment #8373751 - Flags: review?(yurenju.mozilla) → review+
Done, thanks! Just pushed a new version, will merge tomorrow after it goes through another travis run and after I have a chance to update the wiki documentation and product team :)
https://github.com/mozilla-b2g/gaia/commit/a84300a30dd61be065e394c810e6fa350283839a

Talked to product, going to update wiki and email dev-gaia and ffos-tam about the move. Will close this bug after that, which will mean yuren and also remove his repo.
And email sent

https://groups.google.com/forum/#!topic/mozilla.dev.gaia/-hWSOTqJ4z4

Closing out.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.4 S1 (14feb)
You need to log in before you can comment on or make changes to this bug.