969661 - Character Encoding widget stays disabled if you move it to the toolbar from the menu panel while it is disabled

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

STR:
Enter customization mode
Move the Character Encoding widget to the panel
Go to about:home
Open the panel
The character encoding widget should be disabled
Right-click on it and choose "Move to toolbar"
Navigate to www.mozilla.org

ER:
The button in the toolbar becomes enabled.

AR:
The button in the toolbar stays disabled.

Workaround: While on mozilla.org, right-click and move the button back to the menu panel. Then open the menu panel and choose to move it back to the toolbar.

Comment 1

[:Gijs (he/him)]

Attachment: always re-enable Australis character encoding button when it is removed from an area,

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8372622 [details] [diff] [review]
always re-enable Australis character encoding button when it is removed from an area,

Review of attachment 8372622 [details] [diff] [review]:
-----------------------------------------------------------------

This should have a test :)

Comment 3

[:Gijs (he/him)]

Attachment: always re-enable Australis character encoding button when it is removed from an area,

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8372646 [details] [diff] [review]
always re-enable Australis character encoding button when it is removed from an area,

Review of attachment 8372646 [details] [diff] [review]:
-----------------------------------------------------------------

perfect, thanks!

Comment 5

[:Gijs (he/him)]

remote:   https://hg.mozilla.org/integration/fx-team/rev/b6cc210dcb55

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/b6cc210dcb55

Comment 7

[:Gijs (he/him)]

Comment on attachment 8372646 [details] [diff] [review]
always re-enable Australis character encoding button when it is removed from an area,

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Australis
User impact if declined: Moving the character encoding widget to the toolbar in customize mode leaves it disabled in the toolbar
Testing completed (on m-c, etc.): locally, on m-c, has automated test
Risk to taking this patch (and alternatives if risky): none
String or IDL/UUID changes made by this patch: none

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/2fcb2cd1befc