Closed Bug 969672 Opened 6 years ago Closed 6 years ago

Handle declined engines in meta/global

Categories

(Firefox for Android :: Android Sync, defect, P1)

Firefox 29
All
Android
defect

Tracking

()

RESOLVED FIXED
Tracking Status
fennec 29+ ---

People

(Reporter: rnewman, Assigned: rnewman)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

57 bytes, text/x-github-pull-request
nalexander
: feedback+
Details | Review
This is the Android complement to Bug 969669. There will be a follow-up to implement that logic on Android when we add our first engine that desktop doesn't support.
Depends on: 970084
Blocks: 692620
Assignee: nobody → rnewman
Status: NEW → ASSIGNED
Priority: -- → P1
Attached file Proposed patch. v1
Attachment #8388034 - Flags: review?(nalexander)
Comment on attachment 8388034 [details] [review]
Proposed patch. v1

Comments on github, but either this is not doing what it should or I'm not understanding what you intend.  We should talk tomorrow.
Attachment #8388034 - Flags: review?(nalexander) → feedback+
Revised and re-reviewed on GitHub.

Verified behavior against current desktop, complete with handling history/forms.

https://hg.mozilla.org/integration/fx-team/rev/87beb17a445b
https://hg.mozilla.org/mozilla-central/rev/87beb17a445b
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Product: Android Background Services → Firefox for Android
You need to log in before you can comment on or make changes to this bug.