969718 - Fix and re-enable test_peerConnection_bug825703.html and test_peerConnection_errorCallbacks.html

Status: RESOLVED DUPLICATE of bug 950266

(Core :: WebRTC, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

These two tests were disabled in bug 950266 due to the need to land Nuwa ASAP. Rather than disabling them only on B2G, they were disabled across the board on all platforms, whether affected or not.

An attempt to re-enable them on trunk was greeted by a backout due to test bustage. This bug is to track fixing and re-enabling them. At a minimum, for non-B2G platforms. Preferably, all platforms.

Interestingly, b2g28 (v1.3) has no issues with these tests on non-B2G.

The bustage in question:
https://tbpl.mozilla.org/php/getParsedLog.php?id=34317544&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=34316799&tree=Mozilla-Inbound

Comment 1

[Jason Smith [:jsmith]]

I don't see an error in the logs about errorCallbacks, but I am seeing bug 825703's test failing with:

15:40:34     INFO -  2 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/media/tests/mochitest/test_peerConnection_bug825703.html | mozRTCPeerConnection({"iceServers":[{"url":"stun:127.0.0.1"},{"url":"stuns:localhost","foo":""},{"url":"turn:[::1]:3478","username":"p","credential":"p"},{"url":"turns:localhost:3478?transport=udp","username":"p","credential":"p"}]}) succeeds

Comment 2

[Jason Smith [:jsmith]]

Attachment: testcase.html

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Bug 966802 will be merging to m-c soon, so we should be able to re-enable these tests on all platforms.

Comment 4

[Jason Smith [:jsmith]]

(In reply to Ryan VanderMeulen [:RyanVM UTC-5] from comment #3)
> Bug 966802 will be merging to m-c soon, so we should be able to re-enable
> these tests on all platforms.

That patch merging won't resolve the problem here. This is a followup bug filed because turning the tests on after that patch landed revealed a regression in one of the tests (specifically in 825703). The other test should be able to be turned on though.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

(In reply to Jason Smith [:jsmith] from comment #4)
> That patch merging won't resolve the problem here.

I'm aware of that, but I'm saying we should be able to re-enable on B2G as well when this is fixed.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Bug 966802 was just uplifted to b2g28 with these two tests re-enabled. So this bug is only about getting them re-enabled on trunk.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

So I guess we're cool with these remaining broken indefinitely?

Comment 8

[Maire Reavy [:mreavy]]

(In reply to Ryan VanderMeulen [:RyanVM UTC-5] from comment #7)
> So I guess we're cool with these remaining broken indefinitely?

No, we're not.  We're looking at it now.  Sorry for the delay.

Comment 9

[Randell Jesup [:jesup] (needinfo me)]

Since these seem to work locally, I pushed a try:
https://tbpl.mozilla.org/?tree=Try&rev=e1491ba8e67a

Comment 10

[Randell Jesup [:jesup] (needinfo me)]

Try appears to be fully green

Comment 11

[Randell Jesup [:jesup] (needinfo me)]

Landed with the original bug # from the patch (bug 950266) that bounced trying to re-enable them.
https://hg.mozilla.org/integration/mozilla-inbound/rev/752a28fd6b73