Closed Bug 969768 Opened 7 years ago Closed 7 years ago

"Reload application" button not working on browser-helper

Categories

(Firefox OS Graveyard :: Gaia, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: darep, Assigned: darep)

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/32.0.1700.107 Safari/537.36

Steps to reproduce:

I launched Firefox Nightly using a Gaia debug profile.


Actual results:

The "Reload application" button does nothing on Gaia on Firefox Nightly. The Firefox console prints out "wm is undefined"


Expected results:

The current application should reload.
Whoops, I failed to describe the steps to reproduce properly: in addition to running Gaia on Firefox Nightly, I opened up an app and pushed the "Reload application" button on the inspector. The button is added into the inspector via the browser-helper extension that's bundled in Gaia.
Attachment #8372762 - Flags: review?(kgrandon)
Attachment #8372762 - Flags: review?(dietrich)
Attachment #8372762 - Flags: review?(apoirot)
Attachment #8372762 - Flags: review?(alegnadise+bug)
Attachment #8372762 - Flags: review?(21)
Comment on attachment 8372762 [details] [review]
GitHub pull request pointer

Thanks for the patch!
Attachment #8372762 - Flags: review?(kgrandon)
Attachment #8372762 - Flags: review?(dietrich)
Attachment #8372762 - Flags: review?(apoirot)
Attachment #8372762 - Flags: review?(alegnadise+bug)
Attachment #8372762 - Flags: review?(21)
Attachment #8372762 - Flags: review+
Can you please squash using git rebase, then we can land. Thanks!
Assignee: nobody → ajk
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
OK, squashed!
Realized this morning that the silent failing I implemented is actually very bad. Creates a bad developer experience. Should I change that before merge? :)
The changes are done and it should be good now
Flags: needinfo?(kgrandon)
This is great, thanks for fixing it! Been on my list for a while, but haven't gotten around to doing it.
Flags: needinfo?(kgrandon)
Landed in master: https://github.com/mozilla-b2g/gaia/commit/9ec1d098158e27f7f80fe304b0ffb2829f9b0b0d
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.