96989 - Remove View Saved Data from context menu

Status: VERIFIED DUPLICATE of bug 75338

(Toolkit :: Form Manager, defect)

Description

[Blake Ross]

I would like to remove the View Saved Data menuitem from the context menu to
help in the effort to unclutter them.  I eventually would like to remove all 3
of the wallet-related items, but I believe this one is a good start as it
shouldn't really be contentious -- as far as I can tell, it's not specific to
the page you're viewing.

Index: walletContextOverlay.xul
===================================================================
RCS file:
/cvsroot/mozilla/extensions/wallet/resources/content/walletContextOverlay.xul,v
retrieving revision 1.5
diff -u -r1.5 walletContextOverlay.xul
--- walletContextOverlay.xul	2001/08/06 21:48:46	1.5
+++ walletContextOverlay.xul	2001/08/25 22:22:13
@@ -44,9 +44,6 @@
         showItem("context-prefill", (prefillState != hide));
         setDisabledAttr("context-prefill", (prefillState == disable));
 
-        // Display show-saved-dat if either prefill or capture is being displayed
-        showItem("context-formshow", captureState != hide || prefillState != hide);
-
         // Display separator if either prefill or capture is being displayed
         showItem("context-separator", captureState != hide || prefillState !=
hide);
     }
@@ -64,12 +61,6 @@
   <popupset id="contentAreaContextSet" onpopupshowing="initContextItems();"/>
 
   <popup id="contentAreaContextMenu">
-    <menuitem id="context-formshow"
-              label="&formshowCmd.label;"
-              accesskey=""
-              oncommand="formShow();"
-              style="display:none;"
-              insertafter="context-paste"/>
     <menuitem id="context-capture"
               label="&captureCmd.label;"
               accesskey=""
Index: walletOverlay.js
===================================================================
RCS file: /cvsroot/mozilla/extensions/wallet/resources/content/walletOverlay.js,v
retrieving revision 1.7
diff -u -r1.7 walletOverlay.js
--- walletOverlay.js	2001/08/02 19:03:02	1.7
+++ walletOverlay.js	2001/08/25 22:22:13
@@ -112,17 +112,6 @@
       setDisabledAttr("formPrefill", (prefillState == disable));
     }
 */
-
-    function formShow() {
-      window.openDialog(
-          "chrome://communicator/content/wallet/WalletViewer.xul",
-          "_blank",
-          "chrome,titlebar,modal=yes,resizable=yes");
-/* form toolbar is out
-       initToolbarItems(); // need to redetermine which buttons in form toolbar
to enable
-*/
-    }
-
     // Capture the values that are filled in on the form being displayed.
     function formCapture() {
       var walletService =
Components.classes["@mozilla.org/wallet/wallet-service;1"].getService(Components.interfaces.nsIWalletService);

Comment 1

[Stephen P. Morse]

I would ask that you hold off making such a change until the task menu is 
cleaned up and the view-saved-data isn't three menu levels deep.

Comment 2

[Blake Ross]

My build has Edit > View Saved Data, which is why I thought this wouldn't be a
problem at all...

Comment 3

[Stephen P. Morse]

Can you assure me that it's not going to get cut from the edit menu?

Comment 4

[Blake Ross]

Yep, still there.

Comment 5

[Pierre Chanial]

You could be interested in the bugs I have filed about the context menu ergonomy
in the lay-out.
- editable part    : bug 97063
- non-editable part: bug 97069

Comment 6

[Blake Ross]

Doing this as part of bug 75338.

*** This bug has been marked as a duplicate of 75338 ***

Comment 7

[:deanis74]

vrfy dupe