Closed Bug 969901 Opened 12 years ago Closed 10 years ago

Improve the markup on www.mozilla.org

Categories

(www.mozilla.org :: Pages & Content, defect)

Production
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: kohei, Assigned: kohei)

References

(Blocks 1 open bug)

Details

(Whiteboard: [kb=1266608] )

* Use proper HTML5 elements * Add WAI-ARIA landmark roles * Add Schema.org landmark types Here are some examples. Actually it's verbose, but those have different purposes. <body role="document" itemscope itemtype="http://schema.org/WebPage"> <header id="masthead" role="banner" itemscope itemtype="http://schema.org/WPHeader"> <nav id="nav-main" role="navigation" itemscope itemtype="http://schema.org/SiteNavigationElement"> <main role="main" itemprop="mainContentOfPage" itemscope itemtype="http://schema.org/WebPageElement"> <nav class="menu-bar billboard" role="navigation"> <ul role="directory"> <aside class="billboard newsletter-form" role="complementary" itemscope itemtype="http://schema.org/WPSideBar"> <footer id="colophon" role="contentinfo" itemscope itemtype="http://schema.org/WPFooter">
Whiteboard: [kb=1266608]
+1 for adding some aria roles to the templates! There are some useful guidelines here for when authors should/should not explicitly define aria roles in their markup. http://www.w3.org/TR/aria-in-html/#rec For example, as far as I understand it adding <body role="document"> serves no real value, since it is already an implied default.
Yes, I was reading that document. Looks like we don't need role="document. I'll check other roles.
Reading http://schema.org/WebPage, it seems to imply that every web page is already assumed to be declared of type WebPage. If other properties are found to be outside of an itemscope, they are assumed to be about the page. So, I'm a bit confused as to the benefit to adding this (unless I'm mistaken about something?) I'm not opposed to it, just curious so adding to the discussion. But I think we need to consider this before adding these properties to the base template markup. I guess what I'm trying to say is, why do we need to tell Google that all our web pages are web pages? :)
Blocks: 975151
No longer blocks: 975151
Closing just because it hasn't been discussed in a very long time.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.