969924 - clean up FxA/Sync components

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Administration, task)

Description

[:Gavin Sharp [email: [e-mail]]]

Bug 949076 added some FxA components to various products, but I think the intent was for something different. As I see it, we need:

- A component in Firefox to cover Sync UI
- A component in Core to cover shared FxA-related code (services/fxaccounts, essentially)
- A component in Firefox OS to cover accounts-related stuff in general (Firefox OS::FxA works for this)

Firefox for Android and Marketplace are currently not using their FxA components, and Firefox is using its for Sync bugs. So I propose:

a) renaming Firefox::FxA to Firefox::Sync
b) removing Firefox for Android::FxA and Marketplace::FxA
c) adding Core::FxA
d) adjust all component descriptions accordingly

I imagine we can't actually do b) because some bugs lived there in the past (they were filed accidentally). But we can graveyard them or whatever.

Any objections to this plan?

Comment 1

[toxborrow]

No objections.

The original reason the FxA component was created was specifically to manage FxOS dev.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

OK, I've gone ahead and done a) (saved queries changes shouldn't really be much of a problem, it's a relatively new component).

That leaves b) and c), which I'll file separate bugs for.

Comment 3

[Edwin Wong [:edwong]]

Just to summarize:

Desktop 
UI bugs: Firefox:Sync
non UI bugs: Core::FxA

Fx for Android:
*I'm guessing here*
Android UI bugs: Android Background Services:FxA
Android non UI bugs: Android Background Services:Android Sync or Core::FxA

auth/content server issues:
github.com/mozilla/fxa-auth-server
github.com/mozilla/fxa-content-server

sync servers:
mozilla services::sync
mozilla services::token server

ops - issues:
puppet-config 
svcops-oompaloompas
heka/elasticsearch/kibana: mozilla services::operations

Comment 4

[:Gavin Sharp [email: [e-mail]]]

(In reply to Edwin Wong [:edwong] from comment #3)
> Desktop 
> UI bugs: Firefox:Sync

Yes.

> non UI bugs: Core::FxA

Not that simple - it depends on whether the bug is related to Sync specifically (i.e. Mozilla Services::Sync Backend), or to the generic FxAccount authentication/signin code (Core::FxA).

> Fx for Android:
> *I'm guessing here*
> Android UI bugs: Android Background Services:FxA

Sounds right, but ask mfinkle.

> Android non UI bugs: Android Background Services:Android Sync or Core::FxA

I don't think Android uses any Core::FxA code, but I could be wrong.

> auth/content server issues:
> github.com/mozilla/fxa-auth-server
> github.com/mozilla/fxa-content-server
> 
> sync servers:
> mozilla services::sync
> mozilla services::token server
> 
> ops - issues:
> puppet-config 
> svcops-oompaloompas
> heka/elasticsearch/kibana: mozilla services::operations

These all look right, but not my area of expertise.

Comment 5

[James Bonacci [:jbonacci]]

Yep that last section is mostly correct.
(auth/content, sync servers, ops-issues)

sync servers:
Mozilla Services::Server:*
most commonly
Mozilla Services::Server:Core
Mozilla Services::Server:Sync
Mozilla Services::Server:Token
Mozilla Services::Server:Other

Comment 6

[Edwin Wong [:edwong]]

Just to summarize #2:

for must fix in desktop fx29 - add blocks 969593 

Desktop 
sync UI bugs: Firefox:Sync
sync non UI bugs: Mozilla Services::Sync Backend
authentication bugs: Core::FxA

Fx for Android:
Android UI bugs: Android Background Services:FxA
Android non UI bugs: Android Background Services:Android Sync

auth/content server issues:
github.com/mozilla/fxa-auth-server
github.com/mozilla/fxa-content-server

sync servers:
Mozilla Services::Server:*
most commonly
Mozilla Services::Server:Core
Mozilla Services::Server:Sync
Mozilla Services::Server:Token
Mozilla Services::Server:Other

ops - issues:
puppet-config (inside app)
svcops-oompaloompas (outside app)
heka/elasticsearch/kibana: mozilla services::operations

Comment 7

[Mark Côté [:mcote]]

Is there anything left to do here?  I can't tell.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Don't think so.