Closed Bug 969961 Opened 6 years ago Closed 6 years ago

CSS vars support is not-on-release, but CSS vars tests don't know that and will be permaorange March 17th

Categories

(Core :: CSS Parsing and Computation, defect, critical)

defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla30
Tracking Status
firefox27 --- unaffected
firefox28 --- unaffected
firefox29 - fixed
firefox30 --- fixed
firefox-esr24 --- unaffected
b2g18 --- unaffected
b2g-v1.2 --- unaffected
b2g-v1.3 --- unaffected
b2g-v1.3T --- unaffected
b2g-v1.4 --- unaffected

People

(Reporter: philor, Assigned: heycam)

References

Details

Attachments

(1 file)

https://tbpl.mozilla.org/?tree=Try&rev=bc445a9dbee6, current aurora pushed as though it had been merged to beta, is mostly you.
Is https://hg.mozilla.org/try/rev/bc445a9dbee6 sufficient for my try pushes here once I have a patch?
Status: NEW → ASSIGNED
Nope, that define, which lets you ship in the first couple betas but not after that and not releases, is only being used by one pref on 28. Yours is ifdef RELEASE_BUILD, which gets set based on the version number not having an "a" in it, so you want https://hg.mozilla.org/try/rev/ebd7591c5ed7 (that's off aurora, but at least it tells you where to peel the a1 off 30.0a1 for a trunk push).
Thanks.  (Perhaps I should've known that since I landed the original patch to add RELEASE_BUILD.)
No worries, I've asked how RELEASE_BUILD gets set half a dozen times even though I push unsetting it once a week.
Attached patch patchSplinter Review
Attachment #8373067 - Flags: review?(philringnalda)
Comment on attachment 8373067 [details] [diff] [review]
patch

lgtm!
Attachment #8373067 - Flags: review?(philringnalda) → review+
Attachment #8373067 - Attachment is patch: true
https://hg.mozilla.org/mozilla-central/rev/890d5e759a4b
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
QA Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.