969961 - CSS vars support is not-on-release, but CSS vars tests don't know that and will be permaorange March 17th

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Phil Ringnalda (:philor)]

https://tbpl.mozilla.org/?tree=Try&rev=bc445a9dbee6, current aurora pushed as though it had been merged to beta, is mostly you.

Comment 1

[Cameron McCormack (:heycam)]

Is https://hg.mozilla.org/try/rev/bc445a9dbee6 sufficient for my try pushes here once I have a patch?

Comment 2

[Phil Ringnalda (:philor)]

Nope, that define, which lets you ship in the first couple betas but not after that and not releases, is only being used by one pref on 28. Yours is ifdef RELEASE_BUILD, which gets set based on the version number not having an "a" in it, so you want https://hg.mozilla.org/try/rev/ebd7591c5ed7 (that's off aurora, but at least it tells you where to peel the a1 off 30.0a1 for a trunk push).

Comment 3

[Cameron McCormack (:heycam)]

Thanks.  (Perhaps I should've known that since I landed the original patch to add RELEASE_BUILD.)

Comment 4

[Phil Ringnalda (:philor)]

No worries, I've asked how RELEASE_BUILD gets set half a dozen times even though I push unsetting it once a week.

Comment 5

[Cameron McCormack (:heycam)]

Attachment: patch

Comment 6

[Cameron McCormack (:heycam)]

https://tbpl.mozilla.org/?tree=Try&rev=5a742c3efba1

Comment 7

[Phil Ringnalda (:philor)]

Comment on attachment 8373067 [details] [diff] [review]
patch

lgtm!

Comment 8

[Cameron McCormack (:heycam)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/890d5e759a4b
https://hg.mozilla.org/releases/mozilla-aurora/rev/f9e55c14e969

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/890d5e759a4b