969976 - Tabs on close fires for all tabs at launch

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[willmarquardt]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:27.0) Gecko/20100101 Firefox/27.0 (Beta/Release)
Build ID: 20140127194636

Steps to reproduce:

I registered `tabs.on('close', function(tab){console.log('onClose called');})` in exports.main


Actual results:

'onClose called' was printed to the console for each tab


Expected results:

Nothing should have happened. I didn't close any tabs.

Comment 1

[Erik Vold [:erikvold] (please needinfo? me)]

Attachment: https://github.com/mozilla/addon-sdk/pull/1401

Comment 2

[Erik Vold [:erikvold] (please needinfo? me)]

So this seems to work for me, and I see that we don't have a test for it, so I wrote one.

If this is still an issue for you then we'll need better steps to reproduce.

Comment 3

[Jordan Santell [:jsantell] [@jsantell]]

Comment on attachment 8374364 [details] [review]
https://github.com/mozilla/addon-sdk/pull/1401

I'm not sure of a better way to test this, but this seems to work -- maybe rename the test dir to something, 'tab-close-on-startup' sounds like it should be firing that event on startup or something. Or maybe just a reference to the bug number for the future

Comment 4

[willmarquardt]

This could be because I'm installing it with Extention Auto-Installer: https://addons.mozilla.org/en-US/firefox/addon/autoinstaller/

It works normally if I:
- Do cfx run
- Create an xpi and install it
- Remove the exports.main function

Comment 5

[willmarquardt]

*extension

Comment 6

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/3d3187974d528081f1014d433f78003396537336
Bug 969976 - Test that tabs on close events do not fire at launch

https://github.com/mozilla/addon-sdk/commit/2496486cd5966c8ab3356c89779736a85e94ff4c
Merge pull request #1401 from erikvold/969976

Bug 969976 - Test that tabs on close events do not fire at launch r=@jsantell