970076 - crash in libmm-color-convertor.so@0x66e

Status: VERIFIED FIXED

(Core :: Audio/Video, defect)

Description

[Kevin Brosnan [Ex-Mozilla]]

This bug was filed from the Socorro interface and is 
report bp-6f045fd1-4533-43b0-b3d9-523a52140208.
=============================================================

Crash comments and URLs suggest Flash is involved. Only happens on Android 4.3 on devices using Qualcomm Adreno (TM) 225 and Qualcomm Adreno (TM) 320. AT&T, Verizon and Sprint versions of the Galaxy S3 are at the top of the list.

Comment 1

[Aaron Train [:aaronmt]]

Does MV have any of those S3's?

Comment 2

[Aaron Train [:aaronmt]]

My Sony Xperia Tablet Z (SGP311) is showing up on the device listing and I can reproduce.

Steps: play any MP4 on my test-page

http://people.mozilla.org/~atrain/mobile/tests/media.html

I'll try and get a stack from a debug build.

Comment 3

[Aaron Train [:aaronmt]]

Here's an exact video where on play it crashes: http://people.mozilla.org/~atrain/mobile/tests/big-buck-high.mp4

Comment 4

[Aaron Train [:aaronmt]]

As far as I can go without proper symbols

warning: Could not load shared library symbols for libOmxCore.so.
Do you need "set solib-search-path" or "set sysroot"?
warning: Could not load shared library symbols for libstagefright_soft_aacdec.so.
Do you need "set solib-search-path" or "set sysroot"?
warning: Could not load shared library symbols for libmm-color-convertor.so.
Do you need "set solib-search-path" or "set sysroot"?
warning: Could not load shared library symbols for libI420colorconvert.so.
Do you need "set solib-search-path" or "set sysroot"?

Program received signal SIGBUS, Bus error.
[Switching to Thread 17352]
0x854fb66e in ?? ()
(gdb) bt
#0  0x854fb66e in ?? ()
#1  0x854fb850 in ?? ()
#2  0x854fb850 in ?? ()
Backtrace stopped: previous frame identical to this frame (corrupt stack?)

Comment 5

[Aaron Train [:aaronmt]]

Last good revision: 0d11fce4f845 (2013-12-16)
First bad revision: b1e5ade62913 (2013-12-17)
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=0d11fce4f845&tochange=b1e5ade62913

65adb5a76773	Edwin Flores — Bug 866080 - Use Android I420ColorConverter in OMX plugin r=sotaro,doublec

Comment 6

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

Looking at this now.

Comment 7

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

Attachment: Set preferred video colour format for OMX on Android 4.2 and 4.3

Android 4.2 introduced some relatively major changes in the way that Android
negotiates its output colour format. This was fixed on 4.4 KitKat in bug 953394.
This patch just lets Android versions 4.2 and 4.3 use the same fix.

Comment 8

[Kevin Brosnan [Ex-Mozilla]]

If this is reviewed can we land this on trunk soon? Would like to get this in to beta which has about 14 more days before the tree closes for release.

Comment 9

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a15a762f7eef

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a15a762f7eef

Comment 11

[Kevin Brosnan [Ex-Mozilla]]

Arron would you verify?

Comment 12

[Lukas Blakk [:lsblakk] use ?needinfo]

Can we get uplift nomination here so this can be in the next Beta?

Comment 13

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

Comment on attachment 8378055 [details] [diff] [review]
Set preferred video colour format for OMX on Android 4.2 and 4.3

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 953394.
User impact if declined: Android 4.2 and 4.3 devices with Qualcomm SoCs crashing.
Testing completed (on m-c, etc.): Has been on m-c for about a week.
Risk to taking this patch (and alternatives if risky): Minimal.
String or IDL/UUID changes made by this patch: None.

Comment 14

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8378055 [details] [diff] [review]
Set preferred video colour format for OMX on Android 4.2 and 4.3

Approving also for beta (see comment #12 from Lukas)

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/bf3f7ce9b7bf
https://hg.mozilla.org/releases/mozilla-beta/rev/0218f8a426fd

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g28_v1_3/rev/0218f8a426fd