Closed Bug 970159 Opened 7 years ago Closed 7 years ago

media/webrtc/signaling/src/sipcc/core/sdp/sdp_attr_access.c:12537:9 [enabled by default] return makes integer from pointer without a cast

Categories

(Core :: WebRTC: Signaling, defect)

All
Android
defect
Not set
minor

Tracking

()

RESOLVED FIXED
mozilla30
Tracking Status
firefox29 --- unaffected
firefox30 --- fixed

People

(Reporter: cpeterson, Assigned: cpeterson)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

This is a gcc 4.6 warning on Android.
Attachment #8373107 - Flags: review?(rjesup)
Comment on attachment 8373107 [details] [diff] [review]
return-0-not-NULL.patch

Review of attachment 8373107 [details] [diff] [review]:
-----------------------------------------------------------------

canceling review: I can't find the code that this is modifying. Inbound has so such function or code.  Is this against Aurora or Beta?  

I can probably r+ on principle given the apparent signature, if the code exists.  It's hard to be sure when the code doesn't seem to be in the tree.
Attachment #8373107 - Flags: review?(rjesup)
Comment on attachment 8373107 [details] [diff] [review]
return-0-not-NULL.patch

Randell: here is a link to the function in mozilla-central:

https://hg.mozilla.org/mozilla-central/file/ecf20a2484b6/media/webrtc/signaling/src/sipcc/core/sdp/sdp_attr_access.c#l12537
Attachment #8373107 - Flags: review?(rjesup)
Comment on attachment 8373107 [details] [diff] [review]
return-0-not-NULL.patch

Review of attachment 8373107 [details] [diff] [review]:
-----------------------------------------------------------------

r+ - my tree was out of date and this was newly landed code
I'm not in love with the return of a magic value for failure (without a #define) in an API, but that was an issue for the original review. (or a new one)
Attachment #8373107 - Flags: review+
Attachment #8373107 - Flags: review?(rjesup)
https://hg.mozilla.org/mozilla-central/rev/063a9e3da435
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in before you can comment on or make changes to this bug.