970159 - media/webrtc/signaling/src/sipcc/core/sdp/sdp_attr_access.c:12537:9 [enabled by default] return makes integer from pointer without a cast

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, defect)

Description

[Chris Peterson [:cpeterson]]

Attachment: return-0-not-NULL.patch

This is a gcc 4.6 warning on Android.

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8373107 [details] [diff] [review]
return-0-not-NULL.patch

Review of attachment 8373107 [details] [diff] [review]:
-----------------------------------------------------------------

canceling review: I can't find the code that this is modifying. Inbound has so such function or code.  Is this against Aurora or Beta?  

I can probably r+ on principle given the apparent signature, if the code exists.  It's hard to be sure when the code doesn't seem to be in the tree.

Comment 2

[Chris Peterson [:cpeterson]]

Comment on attachment 8373107 [details] [diff] [review]
return-0-not-NULL.patch

Randell: here is a link to the function in mozilla-central:

https://hg.mozilla.org/mozilla-central/file/ecf20a2484b6/media/webrtc/signaling/src/sipcc/core/sdp/sdp_attr_access.c#l12537

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8373107 [details] [diff] [review]
return-0-not-NULL.patch

Review of attachment 8373107 [details] [diff] [review]:
-----------------------------------------------------------------

r+ - my tree was out of date and this was newly landed code
I'm not in love with the return of a magic value for failure (without a #define) in an API, but that was an issue for the original review. (or a new one)

Comment 4

[Chris Peterson [:cpeterson]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/063a9e3da435

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/063a9e3da435