change manifestUrl to manifestURL in WebappManager._autoUpdate's aData argument

RESOLVED FIXED in Firefox 30

Status

()

P3
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: myk, Assigned: mhaigh)

Tracking

unspecified
Firefox 30
ARM
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

5 years ago
WebappManager._autoUpdate gets an aData argument with a "manifestUrl" property, but it has to pass aData to DOMApplicationRegistry.updateHostedApp, which expects it to have a "manifestURL" property, so we have to fix up aData.

It's ok for us to use "manifestUrl" as the name of a variable in files that use that naming scheme, but we should use "manifestURL" as the name of this property in the data object that gets passed to _autoUpdate.
(Reporter)

Updated

5 years ago
Priority: -- → P3
(Assignee)

Updated

5 years ago
Assignee: nobody → mhaigh
(Assignee)

Comment 1

5 years ago
Created attachment 8374898 [details] [diff] [review]
change manifestUrl to manifestURL in WebapManager._autoUpdates aData argument

Not quite sure how to test given a lack of apps I can update, but believe this is solid.  W
Attachment #8374898 - Flags: feedback?
(Assignee)

Updated

5 years ago
Attachment #8374898 - Flags: feedback? → feedback?(myk)
(Reporter)

Comment 2

5 years ago
Comment on attachment 8374898 [details] [diff] [review]
change manifestUrl to manifestURL in WebapManager._autoUpdates aData argument

Review of attachment 8374898 [details] [diff] [review]:
-----------------------------------------------------------------

(In reply to Martyn Haigh (:mhaigh) from comment #1)
> Not quite sure how to test given a lack of apps I can update

mhaigh and I discussed this outside Bugzilla, but for posterity: you can set browser.webapps.updateCheckUrl to http://apk-update-checker.paas.allizom.org to test updates, as it is an alternative update check endpoint that always tells you all your apps are out-of-date.

As for the patch itself, it's a good start!  But you also need to update WebappManager._autoUpdate to remove the code that works around this problem:

http://mxr.mozilla.org/mozilla-central/source/mobile/android/modules/WebappManager.jsm?rev=58ce2022d43b#249
Attachment #8374898 - Flags: feedback?(myk) → feedback+
(Assignee)

Comment 3

5 years ago
Created attachment 8377641 [details] [diff] [review]
change manifestUrl to manifestURL in WebapManager._autoUpdates aData argument

removed old hack
Attachment #8374898 - Attachment is obsolete: true
Attachment #8377641 - Flags: feedback?(myk)
(Reporter)

Comment 4

5 years ago
Comment on attachment 8377641 [details] [diff] [review]
change manifestUrl to manifestURL in WebapManager._autoUpdates aData argument

Review of attachment 8377641 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!
Attachment #8377641 - Flags: review?(wjohnston)
Attachment #8377641 - Flags: feedback?(myk)
Attachment #8377641 - Flags: feedback+
Attachment #8377641 - Flags: review?(wjohnston) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/c7d38d7390b1
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 30
You need to log in before you can comment on or make changes to this bug.