Closed
Bug 970201
Opened 9 years ago
Closed 9 years ago
change manifestUrl to manifestURL in WebappManager._autoUpdate's aData argument
Categories
(Firefox for Android Graveyard :: Web Apps (PWAs), defect, P3)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 30
People
(Reporter: myk, Assigned: mhaigh)
References
Details
Attachments
(1 file, 1 obsolete file)
2.18 KB,
patch
|
wesj
:
review+
myk
:
feedback+
|
Details | Diff | Splinter Review |
WebappManager._autoUpdate gets an aData argument with a "manifestUrl" property, but it has to pass aData to DOMApplicationRegistry.updateHostedApp, which expects it to have a "manifestURL" property, so we have to fix up aData. It's ok for us to use "manifestUrl" as the name of a variable in files that use that naming scheme, but we should use "manifestURL" as the name of this property in the data object that gets passed to _autoUpdate.
Reporter | ||
Updated•9 years ago
|
Priority: -- → P3
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → mhaigh
Assignee | ||
Comment 1•9 years ago
|
||
Not quite sure how to test given a lack of apps I can update, but believe this is solid. W
Attachment #8374898 -
Flags: feedback?
Assignee | ||
Updated•9 years ago
|
Attachment #8374898 -
Flags: feedback? → feedback?(myk)
Reporter | ||
Comment 2•9 years ago
|
||
Comment on attachment 8374898 [details] [diff] [review] change manifestUrl to manifestURL in WebapManager._autoUpdates aData argument Review of attachment 8374898 [details] [diff] [review]: ----------------------------------------------------------------- (In reply to Martyn Haigh (:mhaigh) from comment #1) > Not quite sure how to test given a lack of apps I can update mhaigh and I discussed this outside Bugzilla, but for posterity: you can set browser.webapps.updateCheckUrl to http://apk-update-checker.paas.allizom.org to test updates, as it is an alternative update check endpoint that always tells you all your apps are out-of-date. As for the patch itself, it's a good start! But you also need to update WebappManager._autoUpdate to remove the code that works around this problem: http://mxr.mozilla.org/mozilla-central/source/mobile/android/modules/WebappManager.jsm?rev=58ce2022d43b#249
Attachment #8374898 -
Flags: feedback?(myk) → feedback+
Assignee | ||
Comment 3•9 years ago
|
||
removed old hack
Attachment #8374898 -
Attachment is obsolete: true
Attachment #8377641 -
Flags: feedback?(myk)
Reporter | ||
Comment 4•9 years ago
|
||
Comment on attachment 8377641 [details] [diff] [review] change manifestUrl to manifestURL in WebapManager._autoUpdates aData argument Review of attachment 8377641 [details] [diff] [review]: ----------------------------------------------------------------- Looks good!
Attachment #8377641 -
Flags: review?(wjohnston)
Attachment #8377641 -
Flags: feedback?(myk)
Attachment #8377641 -
Flags: feedback+
Updated•9 years ago
|
Attachment #8377641 -
Flags: review?(wjohnston) → review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Comment 5•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/c7d38d7390b1
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/c7d38d7390b1
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 30
Updated•2 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•