970201 - change manifestUrl to manifestURL in WebappManager._autoUpdate's aData argument

Status: RESOLVED FIXED

Description

[Myk Melez [:myk] [@mykmelez]]

WebappManager._autoUpdate gets an aData argument with a "manifestUrl" property, but it has to pass aData to DOMApplicationRegistry.updateHostedApp, which expects it to have a "manifestURL" property, so we have to fix up aData.

It's ok for us to use "manifestUrl" as the name of a variable in files that use that naming scheme, but we should use "manifestURL" as the name of this property in the data object that gets passed to _autoUpdate.

Comment 1

[Martyn Haigh (:mhaigh)]

Created attachment 8374898 [details] [diff] [review]
change manifestUrl to manifestURL in WebapManager._autoUpdates aData argument

Not quite sure how to test given a lack of apps I can update, but believe this is solid.  W

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 8374898 [details] [diff] [review]
change manifestUrl to manifestURL in WebapManager._autoUpdates aData argument

Review of attachment 8374898 [details] [diff] [review]:
-----------------------------------------------------------------

(In reply to Martyn Haigh (:mhaigh) from comment #1)
> Not quite sure how to test given a lack of apps I can update

mhaigh and I discussed this outside Bugzilla, but for posterity: you can set browser.webapps.updateCheckUrl to http://apk-update-checker.paas.allizom.org to test updates, as it is an alternative update check endpoint that always tells you all your apps are out-of-date.

As for the patch itself, it's a good start!  But you also need to update WebappManager._autoUpdate to remove the code that works around this problem:

http://mxr.mozilla.org/mozilla-central/source/mobile/android/modules/WebappManager.jsm?rev=58ce2022d43b#249

Comment 3

[Martyn Haigh (:mhaigh)]

Created attachment 8377641 [details] [diff] [review]
change manifestUrl to manifestURL in WebapManager._autoUpdates aData argument

removed old hack

Comment 4

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 8377641 [details] [diff] [review]
change manifestUrl to manifestURL in WebapManager._autoUpdates aData argument

Review of attachment 8377641 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c7d38d7390b1

Comment 6

[Wes Kocher (:KWierso)]

https://hg.mozilla.org/mozilla-central/rev/c7d38d7390b1