Closed Bug 970212 Opened 7 years ago Closed 7 years ago

B2G Emulator: Enhance GSM/UMTS Signal Strength on Emulator.

Categories

(Firefox OS Graveyard :: Emulator, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(b2g-v1.4 fixed)

RESOLVED FIXED
1.4 S1 (14feb)
Tracking Status
b2g-v1.4 --- fixed

People

(Reporter: sku, Assigned: sku)

References

Details

Attachments

(2 files, 7 obsolete files)

61 bytes, text/x-github-pull-request
vicamo
: review+
Details | Review
61 bytes, text/x-github-pull-request
vicamo
: review+
Details | Review
Currently, the emulator command for "gsm signal" did not take effect until radio/service state change manually.

It will be better to let "gsm signal" work, we can introduce more marionette test for sophistication then.
Summary: B2G Emulator: Enhance GSM/UMTS Signal Strength on Emulaotr. → B2G Emulator: Enhance GSM/UMTS Signal Strength on Emulator.
Attachment #8373188 - Flags: review?(vyang)
Attachment #8373190 - Flags: review?(vyang)
Comment on attachment 8373190 [details] [review]
Bug 970212 Part2 - B2G Emulator: Enhance GSM/UMTS Signal Strength on Emulator.

Commented on Github.
Attachment #8373190 - Flags: review?(vyang)
Comment on attachment 8373188 [details] [review]
Bug 970212 Part1 - B2G Emulator: Enhance GSM/UMTS Signal Strength on Emulator.

revise title on Github first, then request review again.
Attachment #8373188 - Attachment is obsolete: true
Attachment #8373188 - Flags: review?(vyang)
Comment on attachment 8373190 [details] [review]
Bug 970212 Part2 - B2G Emulator: Enhance GSM/UMTS Signal Strength on Emulator.

revise title on Github first, and change to Reviewer's suggestion, then request review again.
Attachment #8373190 - Attachment is obsolete: true
Blocks: b2g-emulator
Attachment #8373912 - Flags: review?(vyang)
Attachment #8373913 - Flags: review?(vyang)
Hi, commented on Github.
Attachment #8373913 - Flags: review?(vyang) → review+
Comment on attachment 8373912 [details] [review]
Bug 970212 Part1 - B2G Emulator: Enhance GSM/UMTS Signal Strength on Emulator.

revise according to the comment on gitHub first, request review again later.
Attachment #8373912 - Flags: review?(vyang)
Attachment #8375352 - Flags: review?(vyang)
Comment on attachment 8375352 [details] [review]
Bug 970212 Part1 - B2G Emulator: Enhance GSM/UMTS Signal Strength on Emulator. v2.

Need to revise based on suggestion. cancel r? first.
Attachment #8375352 - Flags: review?(vyang)
Comment on attachment 8377356 [details] [review]
Bug 970212 Part1 - B2G Emulator: Enhance GSM/UMTS Signal Strength on Emulator. v3.

1. Add handleSignalStrength to parse signal strength info., and mapping it to
RIL_SignalStrength_v6.
2. Add an unsolicited +CSQ handling to let "gsm signal" command work on emulator.
Attachment #8377356 - Flags: review?(vyang)
Assignee: nobody → sku
Have commented on Github.  We can really pass a pointer of a in-stack RIL_SignalStrength_v6 instance to that handleSignalStrength function and skip those malloc/free mess.
Attachment #8377356 - Attachment is obsolete: true
Attachment #8377356 - Flags: review?(vyang)
Comment on attachment 8377413 [details] [review]
Bug 970212 Part1 - B2G Emulator: Enhance GSM/UMTS Signal Strength on Emulator. v4.

Version 4 address the comment on github.
Attachment #8377413 - Flags: review?(vyang)
0. revise based on the v4 comment.
1. Add handleSignalStrength to parse signal strength info to RIL_SignalStrength_v6.
2. Add an unsolicited +CSQ handling to let "gsm signal" command work on emulator.
3. remove un-necessary RIL_onRequestComplete(t, RIL_E_GENERIC_FAILURE, NULL, 0); at
   requestSignalStrength due to already handle it at error scope.
Attachment #8377413 - Attachment is obsolete: true
Attachment #8377413 - Flags: review?(vyang)
Attachment #8378024 - Flags: review?(vyang)
(In reply to shawn ku [:sku] from comment #17)

I've commented on GitHub yesterday. Not sure if you've seen them.  Mainly some nits and alignments.
Comment on attachment 8378135 [details] [review]
Bug 970212 Part1 - B2G Emulator: Enhance GSM/UMTS Signal Strength on Emulator. v6..

Hi Vicamo:
 Many thanks for your time and comments.

Update v6 patch for the alignment on #3616 - #3618.
Attachment #8378135 - Flags: review?(vyang)
Comment on attachment 8378024 [details] [review]
Bug 970212 Part1 - B2G Emulator: Enhance GSM/UMTS Signal Strength on Emulator. v5.

Thank you :)
Attachment #8378024 - Flags: review+
Verified locally. Going to merge.
Attachment #8378135 - Flags: review?(vyang) → review+
Found mozilla-b2g GitHub owner policy has changed. Permission to merge was revoked. NI sheriff for future GitHub landing process.
Flags: needinfo?(ryanvm)
Keywords: checkin-needed
See dev-gaia, Gaia is currently closed. Also, in the future, just setting checkin-needed is sufficient. I'll merge these if Gaia reopens.
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: needinfo?(ryanvm)
Resolution: --- → FIXED
Target Milestone: --- → 1.4 S1 (14feb)
platform_hardware_ril/master:  7930611ae19f46a5ed467cf86c1403ff3fb0ce25
platform_external_qemu/master: e3f5efa3ba292e345f822104921479b0d6732652
Thank you :)
You need to log in before you can comment on or make changes to this bug.