970214 - Send a weekly "Ready for review" digest

Status: RESOLVED FIXED

(support.mozilla.org :: Knowledge Base Software, task, P3)

Description

[Rosana Ardila]

In order to make it easier for reviewers to keep an eye on the work to do and also as a weekly reminder of SUMO a weekly digest email with the list of the articles waiting for review.

The digest should be per default for each reviewer, but there should be the option of turning it off, for example on the same place where you can ask for the notifications on the dashboard.

Michael: this makes sense for l10n, not sure about En-US.

Let me know if you have any questions!

Thanks,

- Rosana

Comment 1

[Verdi [:verdi] Best to slack me]

This would be helpful for en-US too.

Comment 2

[Rosana Ardila]

Hey, I don't mean to be unpolite. I just wanted to know if this is still on track for Q1 and if there are any questions.

Thanks,

- Rosana

Comment 3

[Kadir Topal [:atopal]]

We can address this in the next sprint starting in 2 weeks.

Ricky, do we need any more information before we can move forward?

Comment 4

[Ricky Rosario [:rrosario, :r1cky]]

(In reply to Kadir Topal [:atopal] from comment #3)
> Ricky, do we need any more information before we can move forward?

I need to wording for the email (subject and body).

Is the opt-out required? That complicates things because it would have to be some sort of new profile setting that would only apply to locale leaders and reviewers.

This is at least 3pts. We might need to break it up further.

Comment 5

[Ricky Rosario [:rrosario, :r1cky]]

Some assumptions:

* It is one email per locale per week that goes to the locale leader and reviewers
* If there are no revisions pending review, no email goes out
* It just shows a list of article titles and links to article history page

What other details are missing?

Comment 6

[Rosana Ardila]

(In reply to Ricky Rosario [:rrosario, :r1cky] from comment #5)
> Some assumptions:
> 
> * It is one email per locale per week that goes to the locale leader and
> reviewers
> * If there are no revisions pending review, no email goes out
> * It just shows a list of article titles and links to article history page
> 
> What other details are missing?

that's about it.

Comment 7

[Rosana Ardila]

(In reply to Ricky Rosario [:rrosario, :r1cky] from comment #4)
> (In reply to Kadir Topal [:atopal] from comment #3)
> > Ricky, do we need any more information before we can move forward?
> 
> I need to wording for the email (subject and body).
> 
> Is the opt-out required? That complicates things because it would have to be
> some sort of new profile setting that would only apply to locale leaders and
> reviewers.
> 
> This is at least 3pts. We might need to break it up further.

the opt-out would be great, but we can build it if contributors complain, it's *just* one email a week.

A first draft for the email would be:

///
Subject: Reviews pending in SUMO

Hi [username],

Our contributors have been working hard on translation some articles and it would be great if you could review them so that they can get published and start helping users.

If you have a moment please help us by reviewing these articles:
xxxx
xxxx
xxxx

Many thanks for your contribution in behalf of SUMO and the happy users who get help!


Regards,

The SUMO team.
///

Michael could you help by using your magic on the copy?

Thanks,

- Rosana

Comment 8

[Ricky Rosario [:rrosario, :r1cky]]

(In reply to Rosana Ardila from comment #7)
> the opt-out would be great, but we can build it if contributors complain,
> it's *just* one email a week.

I like that idea.

We could also add more information to that email in the future. Maybe some of the local metrics would be nice.

Reducing to 2 pts with that simplification.

Comment 9

[Ricky Rosario [:rrosario, :r1cky]]

I had a different idea:

Can we send this digest to all users that are subscribed to the "Waiting for review" notifications of the given locale? In theory, those are the users that care about this and I am guessing most locale reviewers/leaders are subscribed already.

Thoughts?

Comment 10

[Ricky Rosario [:rrosario, :r1cky]]

This should apply to en-US revisions too.

Comment 11

[Rosana Ardila]

(In reply to Ricky Rosario [:rrosario, :r1cky] from comment #9)
> I had a different idea:
> 
> Can we send this digest to all users that are subscribed to the "Waiting for
> review" notifications of the given locale? In theory, those are the users
> that care about this and I am guessing most locale reviewers/leaders are
> subscribed already.
> 
> Thoughts?

I like! Could the notifications subscription be the digest subscription, and by default un-subscription (opt-out) then? 
This makes a lot of sense!

Comment 12

[Rosana Ardila]

after talking to Ricky we decided to go with the option of:

- sending the weekly digest to all reviewers without opt-out for now.

many reviewers might not be subscribed to the notifications and we don't want to spam them

Additionally we thought that it would be beneficial to offer digests for notifications in general. A separate bug should be created for that.

Comment 13

[Verdi [:verdi] Best to slack me]

(In reply to Rosana Ardila from comment #7)
> the opt-out would be great, but we can build it if contributors complain,
> it's *just* one email a week.
> 
I don't think we need an opt-out. This feels like part of the responsibility of being a reviewer. 


(In reply to Ricky Rosario [:rrosario, :r1cky] from comment #9)
> I had a different idea:
> 
> Can we send this digest to all users that are subscribed to the "Waiting for
> review" notifications of the given locale? In theory, those are the users
> that care about this and I am guessing most locale reviewers/leaders are
> subscribed already.
> 
> Thoughts?

I'm not even sure if I'm signed up for that. Where do you do that?


(In reply to Rosana Ardila from comment #7)

> Michael could you help by using your magic on the copy?
> 

How about this?

///
Subject: [Reviews Pending] SUMO needs your help!

Hi [username],
 
Our contributors have been working hard on articles and it would be great if you could review them. The faster we get them published the faster they start helping users.

If you have a moment please review these articles:
xxxx
xxxx
xxxx
 
Many thanks for your contribution on behalf of SUMO and the happy users who are helped by your work!
 
Regards,
The SUMO team
///

Comment 14

[Ricky Rosario [:rrosario, :r1cky]]

(In reply to Verdi [:verdi] from comment #13)
> (In reply to Rosana Ardila from comment #7)
> > the opt-out would be great, but we can build it if contributors complain,
> > it's *just* one email a week.
> > 
> I don't think we need an opt-out. This feels like part of the responsibility
> of being a reviewer. 
> 
> 
> (In reply to Ricky Rosario [:rrosario, :r1cky] from comment #9)
> > I had a different idea:
> > 
> > Can we send this digest to all users that are subscribed to the "Waiting for
> > review" notifications of the given locale? In theory, those are the users
> > that care about this and I am guessing most locale reviewers/leaders are
> > subscribed already.
> > 
> > Thoughts?
> 
> I'm not even sure if I'm signed up for that. Where do you do that?

Oh well. If you aren't signed up, I doubt many others are :)

Right here -> http://cl.ly/image/2d2k1c3G1U0F

Comment 15

[Rosana Ardila]

(In reply to Verdi [:verdi] from comment #13)
> (In reply to Rosana Ardila from comment #7)
> > the opt-out would be great, but we can build it if contributors complain,
> > it's *just* one email a week.
> > 
> I don't think we need an opt-out. This feels like part of the responsibility
> of being a reviewer. 
> 
> 
> (In reply to Ricky Rosario [:rrosario, :r1cky] from comment #9)
> > I had a different idea:
> > 
> > Can we send this digest to all users that are subscribed to the "Waiting for
> > review" notifications of the given locale? In theory, those are the users
> > that care about this and I am guessing most locale reviewers/leaders are
> > subscribed already.
> > 
> > Thoughts?
> 
> I'm not even sure if I'm signed up for that. Where do you do that?
> 
> 
> (In reply to Rosana Ardila from comment #7)
> 
> > Michael could you help by using your magic on the copy?
> > 
> 
> How about this?
> 
> ///
> Subject: [Reviews Pending] SUMO needs your help!
> 
> Hi [username],
>  
> Our contributors have been working hard on articles and it would be great if
> you could review them. The faster we get them published the faster they
> start helping users.
> 
> If you have a moment please review these articles:
> xxxx
> xxxx
> xxxx
>  
> Many thanks for your contribution on behalf of SUMO and the happy users who
> are helped by your work!
>  
> Regards,
> The SUMO team
> ///

Thankd for this copy, sounds perfect to me!

Comment 16

[Rosana Ardila]

(In reply to Ricky Rosario [:rrosario, :r1cky] from comment #14)
> (In reply to Verdi [:verdi] from comment #13)
> > (In reply to Rosana Ardila from comment #7)
> > > the opt-out would be great, but we can build it if contributors complain,
> > > it's *just* one email a week.
> > > 
> > I don't think we need an opt-out. This feels like part of the responsibility
> > of being a reviewer. 
> > 
> > 
> > (In reply to Ricky Rosario [:rrosario, :r1cky] from comment #9)
> > > I had a different idea:
> > > 
> > > Can we send this digest to all users that are subscribed to the "Waiting for
> > > review" notifications of the given locale? In theory, those are the users
> > > that care about this and I am guessing most locale reviewers/leaders are
> > > subscribed already.
> > > 
> > > Thoughts?
> > 
> > I'm not even sure if I'm signed up for that. Where do you do that?
> 
> Oh well. If you aren't signed up, I doubt many others are :)
> 
> Right here -> http://cl.ly/image/2d2k1c3G1U0F

Probably not a lot of people are signed up :/
More reasons to go with the weekly digest without opt-out for now.

Comment 17

[Ricky Rosario [:rrosario, :r1cky]]

Q1 is over. Bring it on, Q2!

Comment 18

[Ricky Rosario [:rrosario, :r1cky]]

looks like we put this in 2013.6 instead of 2014.6. moving to backlog

Comment 19

[Ricky Rosario [:rrosario, :r1cky]]

Deployed to prod now:

https://github.com/mozilla/kitsune/commit/c641962e5ec2d1def934b55f4e6de621918dc8f3