970232 - Fix failure in test_settings_change_keyboard_language.py

Status: RESOLVED DUPLICATE of bug 968083

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Viorela Ioia [:viorela]]

This test fails in the latest build with the following error:
Traceback (most recent call last):
File "/var/jenkins/workspace/b2g.hamachi.mozilla-central.ui.2/.env/local/lib/python2.7/site-packages/marionette_client-0.7.3-py2.7.egg/marionette/marionette_test.py", line 143, in run
testMethod()
File "/var/jenkins/workspace/b2g.hamachi.mozilla-central.ui.2/tests/python/gaia-ui-tests/gaiatest/tests/functional/settings/test_settings_change_keyboard_language.py", line 35, in test_change_keyboard_language_settings
new_contact_form = contacts_app.tap_new_contact()
File "/var/jenkins/workspace/b2g.hamachi.mozilla-central.ui.2/tests/python/gaia-ui-tests/gaiatest/apps/contacts/app.py", line 74, in tap_new_contact
return NewContact(self.marionette)
File "/var/jenkins/workspace/b2g.hamachi.mozilla-central.ui.2/tests/python/gaia-ui-tests/gaiatest/apps/contacts/regions/contact_form.py", line 183, in __init__
done = self.marionette.find_element(*self._done_button_locator)
File "/var/jenkins/workspace/b2g.hamachi.mozilla-central.ui.2/.env/local/lib/python2.7/site-packages/marionette_client-0.7.3-py2.7.egg/marionette/marionette.py", line 1176, in find_element
response = self._send_message('findElement', 'value', **kwargs)
File "/var/jenkins/workspace/b2g.hamachi.mozilla-central.ui.2/.env/local/lib/python2.7/site-packages/marionette_client-0.7.3-py2.7.egg/marionette/marionette.py", line 605, in _send_message
self._handle_error(response)
File "/var/jenkins/workspace/b2g.hamachi.mozilla-central.ui.2/.env/local/lib/python2.7/site-packages/marionette_client-0.7.3-py2.7.egg/marionette/marionette.py", line 626, in _handle_error
raise NoSuchElementException(message=message, status=status, stacktrace=stacktrace)
NoSuchElementException: NoSuchElementException: Unable to locate element: save-button

It also fails locally.

Comment 1

[Viorela Ioia [:viorela]]

Attachment: Github PR: https://github.com/mozilla-b2g/gaia/pull/16119

Comment 2

[Zac C (:zac)]

AndreiH is already working on this problem in this bug:
https://bugzilla.mozilla.org/show_bug.cgi?id=968083

Comment 3

[Zac C (:zac)]

Comment on attachment 8373209 [details] [review]
Github PR: https://github.com/mozilla-b2g/gaia/pull/16119

I don't think this waits for anything valid. when I debug this the element is always displayed.
It's only worth waiting for it to be displayed if it was ever *not* displayed.