Closed
Bug 970283
Opened 11 years ago
Closed 11 years ago
Bump URI version to 1.55 to correctly escape single quotes
Categories
(Bugzilla :: Installation & Upgrading, enhancement)
Tracking
()
RESOLVED
FIXED
Bugzilla 5.0
People
(Reporter: LpSolit, Assigned: LpSolit)
Details
Attachments
(1 file)
|
2.10 KB,
patch
|
dkl
:
review+
|
Details | Diff | Splinter Review |
As reported in bug 926085, single quotes in URLs can cause trouble if they are not escaped. The obsolete RFC 2732, which allowed single quotes to be left unescaped, has been replaced by RFC 3986 which now requires single quotes to be escaped. The URI::Escape module moved to this new RFC in URI 1.53, but it also introduced a regression as it no longer filtered double quotes. This regression has been fixed in URI 1.55. So that's the version we should now require to avoid possible new issues.
|
Assignee | |
Comment 1•11 years ago
|
||
URI::Escape is a submodule of the URI module, so there is no need to duplicate it. URI is already a required module.
Attachment #8373321 -
Flags: review?(dkl)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8373321 [details] [diff] [review]
patch, v1
Review of attachment 8373321 [details] [diff] [review]:
-----------------------------------------------------------------
Works well. r=dkl
Attachment #8373321 -
Flags: review?(dkl) → review+
|
|
Assignee | |
Updated•11 years ago
|
Flags: approval?
|
||
Updated•11 years ago
|
Flags: approval? → approval+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla/Bug.pm
modified Bugzilla/BugUrl.pm
modified Bugzilla/Install/Requirements.pm
Committed revision 8919.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•