Closed
Bug 970298
Opened 10 years ago
Closed 10 years ago
Uplift custom b2g/gaia paths to m-c simulator
Categories
(Firefox OS Graveyard :: Simulator, defect)
Firefox OS Graveyard
Simulator
Tracking
(Not tracked)
RESOLVED
FIXED
2.0 S1 (9may)
People
(Reporter: ochameau, Assigned: ochameau)
References
Details
Attachments
(1 file, 1 obsolete file)
3.38 KB,
patch
|
ochameau
:
review+
|
Details | Diff | Splinter Review |
In bug 929061, we added support for custom gaia/gecko paths in the simulator addon hosted on github. In bug 944451, we are landing the simulator addon in mozilla-central, but that wasn't including bug 929061 changeset. We need to uplift this from github repo to m-c.
Assignee | ||
Comment 1•10 years ago
|
||
The patch ends up being simplier than the github one, as there is no need to copy the prosthesis addon!
Attachment #8410308 -
Flags: review?(jryans)
Comment on attachment 8410308 [details] [diff] [review] patch Review of attachment 8410308 [details] [diff] [review]: ----------------------------------------------------------------- ::: b2g/simulator/lib/simulator-process.js @@ -172,2 @@ > args.push("-profile", profile); > - Cu.reportError(profile); You should still log this somehow, maybe |console.log| or |debug|, but it's helpful to have when debugging issues on random machines.
Attachment #8410308 -
Flags: review?(jryans) → review+
Assignee | ||
Comment 3•10 years ago
|
||
Added a console.log for the profile.
Attachment #8410308 -
Attachment is obsolete: true
Attachment #8411184 -
Flags: review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → poirot.alex
Comment 4•10 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/1d0a4cd6ec20
Keywords: checkin-needed
Comment 5•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1d0a4cd6ec20
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S1 (9may)
You need to log in
before you can comment on or make changes to this bug.
Description
•