970298 - Uplift custom b2g/gaia paths to m-c simulator

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Simulator, defect)

Description

[Alexandre Poirot [:ochameau] [PTO back Jan 5th]]

In bug 929061, we added support for custom gaia/gecko paths in the simulator addon hosted on github. In bug 944451, we are landing the simulator addon in mozilla-central, but that wasn't including bug 929061 changeset.
We need to uplift this from github repo to m-c.

Comment 1

[Alexandre Poirot [:ochameau] [PTO back Jan 5th]]

Attachment: patch

The patch ends up being simplier than the github one,
as there is no need to copy the prosthesis addon!

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8410308 [details] [diff] [review]
patch

Review of attachment 8410308 [details] [diff] [review]:
-----------------------------------------------------------------

::: b2g/simulator/lib/simulator-process.js
@@ -172,2 @@
>      args.push("-profile", profile);
> -    Cu.reportError(profile);

You should still log this somehow, maybe |console.log| or |debug|, but it's helpful to have when debugging issues on random machines.

Comment 3

[Alexandre Poirot [:ochameau] [PTO back Jan 5th]]

Attachment: patch

Added a console.log for the profile.

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/b2g-inbound/rev/1d0a4cd6ec20

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1d0a4cd6ec20