Closed Bug 970506 Opened 6 years ago Closed 6 years ago

Break up ActivityHandlerHelper

Categories

(Firefox for Android :: General, defect)

Product:
Firefox for Android
Component:
General
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 30

People

(Reporter: wesj, Assigned: wesj)

Details

Attachments

(1 file, 1 obsolete file)

Patch
34.84 KB, patch
lucasr
: review+
Details | Diff | Splinter Review 
ActivityHandlerHelper actually does three things.

1.) It provides a simple way to send an intent and pass a callback object to be notified when it returns.

2.) It handles FilePicker messages

3.) It shows a prompt to select an intent

We should break all three up into separate components.
Attached patch Patch (obsolete) — — Splinter Review 
I pulled the chooser code out in bug 971939. This moves the file picking code out of the ActivityHandlerHelper.
Attachment #8375767 - Flags: review?(lucasr.at.mozilla)
Attached patch Patch — — Splinter Review 
As I typed that comment, I realized I had forgotten to remove this from GeckoAppShell too. Just removed the reference there.
Attachment #8375767 - Attachment is obsolete: true
Attachment #8375767 - Flags: review?(lucasr.at.mozilla)
Attachment #8375771 - Flags: review?(lucasr.at.mozilla)
Comment on attachment 8375771 [details] [diff] [review]
Patch

Review of attachment 8375771 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!
Attachment #8375771 - Flags: review?(lucasr.at.mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/20ae4f402369
Assignee: nobody → wjohnston
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 30
You need to log in before you can comment on or make changes to this bug.