Closed
Bug 970506
Opened 11 years ago
Closed 11 years ago
Break up ActivityHandlerHelper
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 30
People
(Reporter: wesj, Assigned: wesj)
Details
Attachments
(1 file, 1 obsolete file)
|
34.84 KB,
patch
|
lucasr
:
review+
|
Details | Diff | Splinter Review |
ActivityHandlerHelper actually does three things.
1.) It provides a simple way to send an intent and pass a callback object to be notified when it returns.
2.) It handles FilePicker messages
3.) It shows a prompt to select an intent
We should break all three up into separate components.
|
Assignee | |
Comment 1•11 years ago
|
||
I pulled the chooser code out in bug 971939. This moves the file picking code out of the ActivityHandlerHelper.
Attachment #8375767 -
Flags: review?(lucasr.at.mozilla)
|
|
Assignee | |
Comment 2•11 years ago
|
||
As I typed that comment, I realized I had forgotten to remove this from GeckoAppShell too. Just removed the reference there.
Attachment #8375767 -
Attachment is obsolete: true
Attachment #8375767 -
Flags: review?(lucasr.at.mozilla)
Attachment #8375771 -
Flags: review?(lucasr.at.mozilla)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8375771 [details] [diff] [review]
Patch
Review of attachment 8375771 [details] [diff] [review]:
-----------------------------------------------------------------
Nice!
Attachment #8375771 -
Flags: review?(lucasr.at.mozilla) → review+
|
||
Comment 4•11 years ago
|
||
Assignee: nobody → wjohnston
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 30
|
||
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•