970512 - Remove uninteresting cases for certificate usage verification

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Attachment: Remove uninteresting cases for certificate usage checks

In bug 878932 I had to map NSS-style certificate usages to (ku, eku, trust bit). This patch removes the cases I didn't add mappings for, which aren't supported by insanity::pkix and which either aren't or don't need to be supported by our NSS-based usage verification. This patch is needed in order to make tests pass when using insanity::pkix.

Comment 1

[Camilo Viecco (:cviecco)]

Comment on attachment 8373563 [details] [diff] [review]
Remove uninteresting cases for certificate usage checks

Review of attachment 8373563 [details] [diff] [review]:
-----------------------------------------------------------------

I want to r+ this, but until we solve the nsNSSCeritifcateDB call we cant remove all the cases listed here.

::: security/manager/ssl/src/nsUsageArrayHelper.cpp
@@ +95,3 @@
>    case certificateUsageSSLCA:
>      typestr = "VerifySSLCA";
>      break;

Cant remove this because of:
https://mxr.mozilla.org/mozilla-central/source/security/manager/ssl/src/nsNSSCertificateDB.cpp#796

But (I think we are failing on this already, ie I think we dont test this case)

Comment 2

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Attachment: Remove uninteresting cases for certificate usage checks [v2]

Thanks for catching that. Here's an updated patch. In this version, I also removed the unneeded named variables in the testing framework.

Comment 3

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1b6cdf3ae69a

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1b6cdf3ae69a

Comment 5

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Comment on attachment 8373830 [details] [diff] [review]
Remove uninteresting cases for certificate usage checks [v2]

[Approval Request Comment]
See bug 878932 comment 37.

Comment 6

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c340ceee9009