97052 - [review]getComputedStyle returns default value for border width when there is no border

Status: RESOLVED FIXED

(Core :: DOM: CSS Object Model, defect, P4)

Description

[tfriesen]

getComputedStyle returns "medium" as the default value for border width even
if there is no border present.

According to CSS2,this value is correct if there is actually a border.
But if the border style has not been set (ie no border),then 
the border width should be "0"

Comment 1

[Boris Zbarsky [:bzbarsky]]

reassign to harish

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: testcase

Comment 3

[harishd]

This is probably a style system bug since getComputedStyle just retrieves values
from stylecontext. CCing pierre.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Actually, in this case the problem is that the stylecontext value should _not_
be used if border is none...  Assumung I understand the style contexts
correctly...

Comment 5

[Pierre Saslawsky]

Thank you Boris for the testcase.  I'll attach a patch.
jst/boris: please review.

Comment 6

[Pierre Saslawsky]

Attachment: patch

Comment 7

[Boris Zbarsky [:bzbarsky]]

Attachment: Better testcase for QA to test on

Comment 8

[Boris Zbarsky [:bzbarsky]]

Pierre, do you really need the temporary |borderStyle| var?  I guess it's a
style issue... not sure what's best there.

Either way, looks good and works perfectly.  r=bzbarsky

Comment 9

[Pierre Saslawsky]

The variable is not necessary.  Separating steps is an inconspicuous habit of 
mine that allows to put conditional breakpoints in debug builds.  In optimized 
builds, I'm fairly sure no assignment is made (or maybe to an internal register, 
and it would have taken place anyhow).

Comment 10

[Johnny Stenback (:jst)]

Comment on attachment 50742 [details] [diff] [review]
patch

sr=jst

Comment 11

[Pierre Saslawsky]

Fix checked into the trunk.