970797 - [LayerScope] One-click connection using firefox addon

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Currently, Layerscope still need to type ip address manually. We want to develop a addon which will detect ip address automatically and then redirect to layerview tool by one click operation.

Comment 1

[u480271]

How does the ip address detection work? Via adb?

Comment 2

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

(In reply to Dan Glastonbury :djg :kamidphish from comment #1)
> How does the ip address detection work? Via adb?

Yes, I'll grep IP address from "adb shell netcfg" command.

Comment 3

[u459114]

Leverage what BenWa had done in GeckoProfiler add on
Reuse two js from that repository
https://github.com/bgirard/Gecko-Profiler-Addon/blob/master/data/CmdRunner.jsm
https://github.com/bgirard/Gecko-Profiler-Addon/blob/master/data/CmdRunWorker.js

Then, you can get IP address in addon:
let cmdRunnerModule = Cu.import(data.url("CmdRunner.jsm"));

function adb_get_netconfig(callback) {
    cmdRunnerModule.runCommand("/bin/bash -l -c 'adb shell netcfg'", function(r) {
      // parse netcfg stdout strings
      var lines = r.split("\n");
      // TODO
    }

Comment 4

[Paul Rouget [:paul]]

We can already do something like that with the devtools (binding device IP port to local port). By default, on the device we use a unix socket that we bind to a localhost tcp socket. But it's possible to do TCP->TCP.

See the first 10 seconds of the video here: https://developer.mozilla.org/en-US/Firefox_OS/Using_the_App_Manager

Maybe there's something we can do with the layer scope and the app manager.

Comment 5

[u459114]

I am not familiar with the implementation of app-manager, by looking through bugzilla and MDN, I think app-manager using adb helper add-on to execute adb command in about:app-manager page:
https://github.com/ochameau/adbhelper

Paul, please correct me if I am wrong, and thanks for your great information

Comment 6

[Paul Rouget [:paul]]

(In reply to C.J. Ku[:CJKu] from comment #5)
> I am not familiar with the implementation of app-manager, by looking through
> bugzilla and MDN, I think app-manager using adb helper add-on to execute adb
> command in about:app-manager page:
> https://github.com/ochameau/adbhelper
> 
> Paul, please correct me if I am wrong, and thanks for your great information

Yes, we use the adb helper, which only job is to do a adb forward. And we are also working on a wireless solution (tcp based).

Comment 7

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

I work with Paul on the App Manager.  I think it would be great to integrate this tool with the App Manager in some way.  We could:

* Make the App Manager capable of detecting devices where Layer Scope is enabled
* When it is enabled, show a button that opens the Layer Scope viewer tool connected to the right IP and port

In the "future" / sometime, it would be great for the App Manager to take advantage of this functionality to recreate a live view of the device's screen.

So, I think it would be nice to start by taking advantage of the App Manager to at least ease connection to the existing Layer Scope viewer tool.  That way there's no add-on to write and have people install.

Comment 8

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

WIP LayerScope-Addon repo here, https://github.com/mephisto41/LayerScope-Addon
And this addon needs modified version of adbhelper. Modified version of adbhelper link: https://github.com/mephisto41/adbhelper

Right now when you open the addon's panel. It will detect adb device automatically. Then select device and press connect and then layerview tool will open and connect to device.

Comment 9

[u459114]

Morris, awesome, it's work!
Some suggestion:
1. Please pull-request what you change into original adbhelper repository - looks like you need an API to setup forward port number.
2. Listen to device connected event - list connected device id in drop down list automatically

Comment 10

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Attachment: adbhelper_supports_custom_remote_port

In the LayerScope, we have to connect to custom remote port instead of debugger-socket. So I slightly modify main.js to support custom remote port.

Comment 11

[Alexandre Poirot [:ochameau]]

Note that there is also libadb.js addon being hosted here:
  https://github.com/mozilla/libadb.js/
So far, it isn't stable enough, but at some point we may be switching to it.
It could be worth also patching it.

Comment 12

[u459114]

Morris, please update wiki page before bug close.
We do give two choices for user, he may use this add-on or execute adb command and manually key in port number. The second one is more like a backup solution in case something wrong in plug-in or a user just doesn't want to use add-on.

Comment 13

[Boris Chiou [:boris]]

Attachment: Fix for newer sdk and gecko.

Comment 14

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Comment on attachment 8547420 [details] [review]
Fix for newer sdk and gecko.

Nice job!!!

Comment 15

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Merged to github!