970915 - Music test - return elapsed time as a time object and assert appropriately

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect, P3)

Description

[Zac C (:zac)]

The music app object returns the time the song has been playing for as a text string. This means is has to match exactly with 00:05 for the test to pass.

3 tasks:
- Return the elapsed time as a python time object
- In the play testss wait_for_condition to be >= to 00:03
- Code the minimum timeout into the wait to be at least the duration that we expect for the song to have started playing, eg 10 seconds.

We already do similar in the video app object - you can look to it for code samples.

Comment 1

[kevin lau]

Hey there,

Can I work on this bug?

Comment 2

[Zac C (:zac)]

You sure can Kevin!

Are you experienced with our test suite already? What do you need to know about getting started, any more questions?

Comment 3

[kevin lau]

I don't have any experience with the test suite. Is there a reference I could use to get setup?

Comment 4

[Zac C (:zac)]

Kevin, 
this will help you get started with running the tests:
https://developer.mozilla.org/en-US/Firefox_OS/Platform/Automated_testing/gaia-ui-tests/Gaia_UI_Tests_Run_Tests#Testing_on_Desktopb2g_%28Firefox_OS_desktop_client%29

Take note of the pre-requisites.

It'd be a good idea just to get the tests running on your computer and get familiar with that before you start to modify them.

In this particular case you'll need to get a music file to be read by desktopb2g (I think it goes in ~/Music/ folder).

Any more questions you can find us all in #mozwebqa on irc.mozilla.

Stay in touch :)

Comment 5

[Zac C (:zac)]

Re-setting for community.

Comment 6

[Florin Strugariu [:Bebe]]

I will give this a try

Comment 7

[Florin Strugariu [:Bebe]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/21291

Comment 8

[Zac C (:zac)]

Comment on attachment 8449509 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/21291

what about the `player_current_timestamp` property? These two could probably be merged.

Comment 9

[Florin Strugariu [:Bebe]]

Comment on attachment 8449509 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/21291

Zac the 2 elements can't be merged.

player_current_timestamp returns the 'currentTime' property of the <audio> element from the app (The actual element that is paling the song) 

  It indicates the position for the playback of the audio/video, in seconds (float) ex: u'9.482502'

player_elapsed_time returns the value of the html element that is visible on the screen and shows the current time 
  It indicates the position for the playback of the audio/video, in minutes and seconds (str) ex: 00:09

Comment 10

[Zac C (:zac)]

Comment on attachment 8449509 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/21291

Ok bebe, I understand now. let's keep it that way!

r+

Comment 11

[Florin Strugariu [:Bebe]]

https://github.com/mozilla-b2g/gaia/commit/59021dcd480a34cfe4f744ccb57b4031bed0a83f