Closed Bug 970977 Opened 9 years ago Closed 9 years ago

Reftests for bug 477915

Categories

(Core :: MathML, defect)

Product:
Core
Component:
MathML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla30

People

(Reporter: anujagarwal464, Assigned: anujagarwal464)

References

Details

Attachments

(1 file, 4 obsolete files)

reftests for bug 477915
6.53 KB, patch
fredw
: review+
Details | Diff | Splinter Review 
User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:27.0) Gecko/20100101 Firefox/27.0 (Beta/Release)
Build ID: 20140127194636
OS: Windows 8 → All
Hardware: x86_64 → All
Assignee: nobody → anujagarwal464
Component: General → MathML
Attached patch reftests for bug 477915 (obsolete) — — Splinter Review 

        Attachment #8374123 -
        Flags: review?(fred.wang)

    
    

    
  
Comment on attachment 8374123 [details] [diff] [review]
reftests for bug 477915

Review of attachment 8374123 [details] [diff] [review]:
-----------------------------------------------------------------

Can you please rename the files

mo-movablelimits-dynamic.html
munderover-accent-dynamic.html
etc

and modify the <title> accordingly

    
    

    
  

      
      
      
      

        Attached patch
          
          
        reftests for bug 477915 (obsolete)
        — 
          — Splinter Review
      

    


  
fixed name of html files

        Attachment #8374123 -
        Attachment is obsolete: true

        Attachment #8374123 -
        Flags: review?(fred.wang)

        Attachment #8374147 -
        Flags: review?(fred.wang)

    
    

    
  
Comment on attachment 8374147 [details] [diff] [review]
reftests for bug 477915

Review of attachment 8374147 [details] [diff] [review]:
-----------------------------------------------------------------

OK, actually there are 4 attributes (mo@movablelimits, mo@accent, munderover@accent and munderover@accentunder) so there should be 4 tests. You still need to update the <title> elements since they don't test "displaystyle".

    
    

    
  

      
      
      
      

        Attached patch
          
          
        reftests for bug 477915 (obsolete)
        — 
          — Splinter Review
      

    


  
fixed title and name of html files

        Attachment #8374147 -
        Attachment is obsolete: true

        Attachment #8374147 -
        Flags: review?(fred.wang)

        Attachment #8374152 -
        Flags: review?(fred.wang)

    
    

    
  
Ok I will add one more test.

    
    

    
  

      
      
      
      

        Attached patch
          
          
        reftests for bug 477915 (obsolete)
        — 
          — Splinter Review
      

    


  
1. Added one more test
2. Fixed titles

        Attachment #8374152 -
        Attachment is obsolete: true

        Attachment #8374152 -
        Flags: review?(fred.wang)

        Attachment #8374183 -
        Flags: review?(fred.wang)

    
    

    
  
Comment on attachment 8374183 [details] [diff] [review]
reftests for bug 477915

Review of attachment 8374183 [details] [diff] [review]:
-----------------------------------------------------------------

mo-movablelimits-accent-dynamic should be mo-accent-dynamic

    
    

    
  


  
Fixed html name

        Attachment #8374183 -
        Attachment is obsolete: true

        Attachment #8374183 -
        Flags: review?(fred.wang)

        Attachment #8374210 -
        Flags: review?(fred.wang)

    
    

    
  
Comment on attachment 8374210 [details] [diff] [review]
reftests for bug 477915

Review of attachment 8374210 [details] [diff] [review]:
-----------------------------------------------------------------

OK, it looks good now. Thanks!

        Attachment #8374210 -
        Flags: review?(fred.wang) → review+

    
  
Keywords: checkin-needed

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/0489e6fcf52e
Status: UNCONFIRMED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
Depends on: 477915

          You need to log in
          before you can comment on or make changes to this bug.