Closed
Bug 970977
Opened 12 years ago
Closed 12 years ago
Reftests for bug 477915
Categories
(Core :: MathML, defect)
Core
MathML
Tracking
()
RESOLVED
FIXED
mozilla30
People
(Reporter: anujagarwal464, Assigned: anujagarwal464)
References
Details
Attachments
(1 file, 4 obsolete files)
|
6.53 KB,
patch
|
fwang
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:27.0) Gecko/20100101 Firefox/27.0 (Beta/Release)
Build ID: 20140127194636
| Assignee | ||
Updated•12 years ago
|
OS: Windows 8 → All
Hardware: x86_64 → All
Updated•12 years ago
|
Assignee: nobody → anujagarwal464
| Assignee | ||
Updated•12 years ago
|
Component: General → MathML
| Assignee | ||
Comment 1•12 years ago
|
||
Attachment #8374123 -
Flags: review?(fred.wang)
Comment 2•12 years ago
|
||
Comment on attachment 8374123 [details] [diff] [review]
reftests for bug 477915
Review of attachment 8374123 [details] [diff] [review]:
-----------------------------------------------------------------
Can you please rename the files
mo-movablelimits-dynamic.html
munderover-accent-dynamic.html
etc
and modify the <title> accordingly
| Assignee | ||
Comment 3•12 years ago
|
||
fixed name of html files
Attachment #8374123 -
Attachment is obsolete: true
Attachment #8374123 -
Flags: review?(fred.wang)
Attachment #8374147 -
Flags: review?(fred.wang)
Comment 4•12 years ago
|
||
Comment on attachment 8374147 [details] [diff] [review]
reftests for bug 477915
Review of attachment 8374147 [details] [diff] [review]:
-----------------------------------------------------------------
OK, actually there are 4 attributes (mo@movablelimits, mo@accent, munderover@accent and munderover@accentunder) so there should be 4 tests. You still need to update the <title> elements since they don't test "displaystyle".
| Assignee | ||
Comment 5•12 years ago
|
||
fixed title and name of html files
Attachment #8374147 -
Attachment is obsolete: true
Attachment #8374147 -
Flags: review?(fred.wang)
Attachment #8374152 -
Flags: review?(fred.wang)
| Assignee | ||
Comment 6•12 years ago
|
||
Ok I will add one more test.
| Assignee | ||
Comment 7•12 years ago
|
||
1. Added one more test
2. Fixed titles
Attachment #8374152 -
Attachment is obsolete: true
Attachment #8374152 -
Flags: review?(fred.wang)
Attachment #8374183 -
Flags: review?(fred.wang)
Comment 8•12 years ago
|
||
Comment on attachment 8374183 [details] [diff] [review]
reftests for bug 477915
Review of attachment 8374183 [details] [diff] [review]:
-----------------------------------------------------------------
mo-movablelimits-accent-dynamic should be mo-accent-dynamic
| Assignee | ||
Comment 9•12 years ago
|
||
Fixed html name
Attachment #8374183 -
Attachment is obsolete: true
Attachment #8374183 -
Flags: review?(fred.wang)
Attachment #8374210 -
Flags: review?(fred.wang)
Comment 10•12 years ago
|
||
Comment on attachment 8374210 [details] [diff] [review]
reftests for bug 477915
Review of attachment 8374210 [details] [diff] [review]:
-----------------------------------------------------------------
OK, it looks good now. Thanks!
Attachment #8374210 -
Flags: review?(fred.wang) → review+
| Assignee | ||
Updated•12 years ago
|
Keywords: checkin-needed
Comment 11•12 years ago
|
||
Flags: in-testsuite+
Keywords: checkin-needed
Comment 12•12 years ago
|
||
Status: UNCONFIRMED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in
before you can comment on or make changes to this bug.
Description
•