971032 - elasticsearch host is wrong on jenkins

Status: RESOLVED FIXED

(Socorro :: General, task)

Description

[[DEACTIVATED] Adrian Gaudebert]

There is a bug in our current integration tests, they do not use the correct elasticsearch host on jenkins (localhost instead of jenkins-es). This needs to be fixed, the local ES is not up-to-date and will disappear soon.

Comment 1

[Lonnen :lonnen]

The unit tests are already using the correct ES. We bundle all the variables for those unit tests together, and they form a subset of the variables we need for the other test sets.

I put a patch together that reuses those bundles where we can. I'm pretty sure it fixes this without causing other complications. Have a look:

https://github.com/mozilla/socorro/pull/1875

Comment 2

[Lonnen :lonnen]

You may be more interested in the Jenkins output, which reveals what gets used: https://ci.mozilla.org/job/socorro-github/2730/console

search for the expected host and you'll see

Comment 3

[[DEACTIVATED] Adrian Gaudebert]

My work on pull requests https://github.com/mozilla/socorro/pull/1845 and https://github.com/mozilla/socorro/pull/1857 showed that this is not true. The configuration that we pass down might be correct, but the underlying test configuration does not take it into account. 

See this for example: https://ci.mozilla.org/job/socorro-github/2698/console It clearly shows that those tests try to query localhost:9200 instead of jenkins-es:9200. 

I have been running some test commits to demonstrate this problem here: https://github.com/mozilla/socorro/pull/1870

And my pull request to fix this problem is here: https://github.com/mozilla/socorro/pull/1872 (where I tell our test configuration to take os.environ into account. )

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/7a85dabaa69166258bc2fb7d1140e51c544b7fb1
Fixes bug 971032 - Correctly pass the elasticsearch host to unit tests in jenkins.

https://github.com/mozilla/socorro/commit/31232a8f827af70817b584d590855e633c50f8c5
Fixes bugs 971032 and 971919 - Fixed delay before failure in unit tests, fixed elasticsearch host everywhere.

https://github.com/mozilla/socorro/commit/ef81147305171d0cdd9b4d3b09fa128a1efa1c1a
Merge pull request #1872 from AdrianGaudebert/971032-fix-jenkins-es-host

Fixes bug 971032 - Correctly pass the elasticsearch host to unit tests i...