971162 - [B2G][Clock][Alarm] Clock alarm has vibration when alarm vibration is set to off

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Clock, defect)

Description

[Brogan Zumwalt [Inactive]]

Attachment: Logcat

Description:
When user creates new alarm in Clock app, setting the vibration to "off" in that alarm's settings does not prevent phone from vibrating when alarm fires.

Repro Steps:
1) Updated Buri to BuildID: 20140211040200
2) Open Clock app
3) Tap new alarm icon in top right corner
4) Set alarm for future time with vibration set to "off"
5) Select "Done"
6) Wait for alarm to fire

Actual:
Alarm with vibration set to "off" still has vibration when alarm fires.

Expected:
Alarm with vibration set to "off" has no vibration when alarm fires.

Environmental Variables:
Device: Buri v1.4 Mozilla RIL
BuildID: 20140211040200
Gaia: 9fc36dde3a4a3c5ca200275b68ffb56b4173bec3
Gecko: d812f80a0f1d
Version: 30.0a1
Firmware Version: V1.2-device.cfg

Notes:
Repro frequency: 3/3, 100%
See attached: logcat

Comment 1

[Natalya Kot [:nkot]]

Fails very basic functionality... 

Works fine on 1.3 - doesn't vibrate when set to Off, vibrates when set to On
Buri v1.3
BuildID: 20140211004035
Gaia: 00cd1ae74dfe773a41b55275b0b468a62f35076d
Gecko: 873e98e750bf
Version: 28.0
Firmware Version: v1.2-devices.cfg

Comment 2

[Matthew Vaughan]

This issue started reproducing on the 01/17/14 Master (1.4) build.

- Works -
Device: Buri v1.4 MOZ RIL
BuildID: 20140116040206
Gaia: 82878ba16172213cd00ba3e8b377564b290e59c1
Gecko: 324e2cba1029
Version: 29.0a1
Firmware Version: V1.2-device.cfg

- Broken -
Device: Buri v1.4 MOZ RIL
BuildID: 20140117041037
Gaia: ef8bb31b462f364b57432a0724c78034d3f4f303
Gecko: b53589696cf8
Version: 29.0a1
Firmware Version: V1.2-device.cfg

Comment 3

[Marcus Cavanaugh [:mcav]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/16228

Comment 4

[Gareth Aye [:gaye] (back from PTO)]

Comment on attachment 8375107 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/16228

Nice job mcav :)

Comment 5

[Marcus Cavanaugh [:mcav]]

Thanks Gareth! Landed in master:

https://github.com/mozilla-b2g/gaia/commit/3c54aedf659b4792e4a1eb1f3ede8b266138cef7

Comment 6

[Dylan Oliver [:doliver]]

Comment on attachment 8375107 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/16228

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined:
[Testing completed]:
[Risk to taking this patch] (and alternatives if risky):
[String changes made]:

Comment 7

[Dylan Oliver [:doliver]]

Fabrice, this one already landed this afternoon but flagging you to take a look and let us know if any further action is required.

Comment 8

[Dylan Oliver [:doliver]]

Comment on attachment 8375107 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/16228

Clearing approval request -- this is for 1.4.

Comment 9

[Marcus Cavanaugh [:mcav]]

Reopening to figure out why the tests are sad.

Comment 10

[bhavana bajaj [:bajaj]]

Can we please do a backout to start with to avoid the smoketest failures ?

Comment 11

[Marcus Cavanaugh [:mcav]]

Sorry for being unclear; the patch was backed out as of yesterday, in line with Comment 9. I'm going to land a proper fix today.

Comment 12

[Marcus Cavanaugh [:mcav]]

Relanded in master:

https://github.com/mozilla-b2g/gaia/commit/49e7bbda552eb7ce45ecd20d22ccdf7eaabe35af

Still awaiting results from TBPL; will reopen/back out if there are any further problems (none anticipated).

Comment 13

[Natalya Kot [:nkot]]

Verified fixed.
Alarm with vibration set to "off" has no vibration when alarm fires.

Buri, master build:
BuildID: 20140219040204
Gaia: ac06cfbd2baf6494ffbb668cc599e3892cd5e17b
Gecko: bf0e76f2a7d4
Version: 30.0a1
v1.2-devices.cfg