971250 - Cookie Monster add-on should not rely on DOM presence of button to auto-add its button

Status: RESOLVED FIXED

(WebExtensions :: General, defect)

Description

[u498184]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:29.0) Gecko/20100101 Firefox/29.0 (Beta/Release)
Build ID: 20140211004037

Steps to reproduce:

1) Install Cookie Monster extension (https://addons.mozilla.org/en-US/firefox/addon/cookie-monster/) on a blank profile
2) Move Cookie Monster icon to the new panel
3) Restart Browser


Actual results:

Icon reverts to the main toolbar


Expected results:

Icon should stay on the panel it was moved to

Comment 1

[Emanuel H.]

Lastpass icon also returns to main toolbar when you restart Firefox.

Comment 2

[Justin Dolske [:Dolske]]

Semi-related: bug 973074?

Calling this P2, having customization not work correctly is a significant problem. (If this ends up being addon-specific it should be lower, though).

Comment 3

[:Gijs (he/him)]

STR on pre-Australis: move the button to the palette, and it'll also come back automatically (even if you just open a new window).

This is an issue with the add-on, which auto-reinserts itself if it can't find the button in the DOM. We could have fixed the panel case described in comment #0 by fixing bug 941903, but the performance impact of it was large enough that I deemed it wasn't worth it. Either way, even then the add-on would still be broken as regards customization.

I'll look at lastpass next and reopen bug 940227 if that's not an SDK issue. I think the SDK has been updated to avoid reinsertion; if lastpass still package an outdated SDK, then there's little we can do, although I guess we could reopen the bug as an evangelism one.

Comment 4

[:Gijs (he/him)]

(In reply to aney91 from comment #1)
> Lastpass icon also returns to main toolbar when you restart Firefox.

https://bugzilla.mozilla.org/show_bug.cgi?id=940227#c4

Comment 5

[Jorge Villalobos [:jorgev] (he/him)]

The developers have been informed about this. We will give them some time to react, otherwise the add-on will be marked as incompatible.

Comment 6

[Jorge Villalobos [:jorgev] (he/him)]

Update: the developer has responded and is working on a fix.

Comment 7

[Jorge Villalobos [:jorgev] (he/him)]

The add-on was marked as incompatible. Nothing else to do here.