Closed Bug 971265 Opened 10 years ago Closed 10 years ago

Add --no-remove-empty-directories to process_install_manifest.py

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla30

People

(Reporter: nalexander, Assigned: nalexander)

Details

Attachments

(2 files)

Pre: Don't write file in test_util.py. r=gps
1.24 KB, patch
nalexander
: review+
Details | Diff | Splinter Review
Add --no-remove-empty-directories to process_install_manifest.py. r=gps
6.52 KB, patch
gps
: review+
Details | Diff | Splinter Review 
Over in https://bugzilla.mozilla.org/show_bug.cgi?id=853045#c41 I added this.  Breaking out a separate ticket for additional test and landing.

This ticket tracks adding a --no-remove-empty-directories option similar to --no-remove.
Comment on attachment 8374446 [details] [diff] [review]
Pre: Don't write file in test_util.py. r=gps

Review of attachment 8374446 [details] [diff] [review]:
-----------------------------------------------------------------

Carrying over trivial review from https://bugzilla.mozilla.org/show_bug.cgi?id=853045#c40.
Attachment #8374446 - Flags: review+
(In reply to Nick Alexander :nalexander from comment #2)
> Created attachment 8374447 [details] [diff] [review]
> Add --no-remove-empty-directories to process_install_manifest.py. r=gps

Now with a test.
Attachment #8374447 - Flags: review?(gps) → review+
https://hg.mozilla.org/mozilla-central/rev/7812cc0ea795
https://hg.mozilla.org/mozilla-central/rev/fa1585a40c13
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.