971265 - Add --no-remove-empty-directories to process_install_manifest.py

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Nick Alexander :nalexander [he/him]]

Over in https://bugzilla.mozilla.org/show_bug.cgi?id=853045#c41 I added this.  Breaking out a separate ticket for additional test and landing.

This ticket tracks adding a --no-remove-empty-directories option similar to --no-remove.

Comment 1

[Nick Alexander :nalexander [he/him]]

Attachment: Pre: Don't write file in test_util.py. r=gps

Comment 2

[Nick Alexander :nalexander [he/him]]

Attachment: Add --no-remove-empty-directories to process_install_manifest.py. r=gps

Comment 3

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8374446 [details] [diff] [review]
Pre: Don't write file in test_util.py. r=gps

Review of attachment 8374446 [details] [diff] [review]:
-----------------------------------------------------------------

Carrying over trivial review from https://bugzilla.mozilla.org/show_bug.cgi?id=853045#c40.

Comment 4

[Nick Alexander :nalexander [he/him]]

(In reply to Nick Alexander :nalexander from comment #2)
> Created attachment 8374447 [details] [diff] [review]
> Add --no-remove-empty-directories to process_install_manifest.py. r=gps

Now with a test.

Comment 5

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7812cc0ea795
https://hg.mozilla.org/integration/mozilla-inbound/rev/fa1585a40c13

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7812cc0ea795
https://hg.mozilla.org/mozilla-central/rev/fa1585a40c13