Closed Bug 971279 Opened 6 years ago Closed 6 years ago

Add Java Test Plugin

Categories

(Core :: Plug-ins, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla30

People

(Reporter: johns, Assigned: johns)

Details

Attachments

(3 files, 7 obsolete files)

Originally in bug 738396, but needed more work. Being able to test all the special-cased stuff for java is a plus.
Attached patch Add plugin.java.mime (obsolete) — Splinter Review
Originally I had a hack in nsObjectLoadingContent to check for x-java-test for <applet> in debug builds, but that breaks on OS X which has a default java plugin. And since we store the pref for both addons as "plugin.state.java" or whathaveyou disabling one and not the other is broken (and not worth fixing)

We also have "application/x-java-vm" hardcoded in a ton of spots to specify magic java behavior, it seems saner to just store this as a pref. Which then lets tests flip the pref to the java test plugin!
Attachment #8374463 - Flags: review?(benjamin)
Attached patch Add nptest java plugin (obsolete) — Splinter Review
This was r+'d in 738396 ages ago, but was bit-rotted to hell, and the old hacks that plugin.java.mime obsoletes removed. Feel free to rubber stamp.
Attachment #8374464 - Flags: review?(benjamin)
(In reply to John Schoenick [:johns] from comment #1)
> Originally I had a hack in nsObjectLoadingContent to check for x-java-test
> for <applet> in debug builds, but that breaks on OS X

It also doesn't allow testing other magic-cases like <object classid="java:">
Attachment #8374464 - Flags: review?(benjamin) → review+
Attachment #8374463 - Flags: review?(benjamin) → review+
This hit issues on try due to us blacklisting DLLs beginning with "npjava". I don't want to touch that, so s/npjavatest/nptestjava/

I also just made IsJavaMIME() read and recognize java.plugin.mime, rather than the debug-specific application/x-java-test hack.

Uploading these two changes for additional r? due to messing-with-java-plumbing paranoia
Attachment #8377917 - Flags: review?(benjamin)
Attachment #8377917 - Flags: review?(benjamin) → review+
Attachment #8374464 - Attachment is obsolete: true
Attachment #8377917 - Attachment is obsolete: true
Attachment #8379264 - Flags: review+
Folded for landing
Attachment #8374463 - Attachment is obsolete: true
Attachment #8379265 - Flags: review+
(In reply to Wes Kocher (:KWierso) from comment #8)
> XPCShell failure:
> https://tbpl.mozilla.org/php/getParsedLog.php?id=35003355&tree=Mozilla-
> Inbound

TEST-UNEXPECTED-FAIL | /builds/slave/test/build/tests/xpcshell/tests/services/healthreport/tests/xpcshell/test_provider_addons.js | 3 == 2 - See following stack:

Ouch, we should just check based on the plugin tag count here.
Attached patch Fix FHR addons provider test. (obsolete) — Splinter Review
Attachment #8379700 - Flags: review?(gps)
Attached patch Fix FHR addons provider test. (obsolete) — Splinter Review
Attachment #8379700 - Attachment is obsolete: true
Attachment #8379700 - Flags: review?(gps)
Attachment #8379702 - Flags: review?(gps)
So the assertion failure in a random crash test was CnP fail, the second assert should be nsPluginHost::IsJavaMIME(javaMIME)
Attachment #8379265 - Attachment is obsolete: true
Attachment #8379956 - Flags: review+
With the fix we move on to failing slightly lower down. Even more fixage!
Attachment #8379702 - Attachment is obsolete: true
Attachment #8379702 - Flags: review?(gps)
Attachment #8379964 - Flags: review?(gps)
Another try push later... test_provider_addons.js still fails. Only on OS X. Because the capitalization in Info.plist didn't match nptest.rc. And this test wants the exact plugin description to match. Just in case.
Attachment #8379264 - Attachment is obsolete: true
Attachment #8380081 - Flags: review+
Comment on attachment 8379964 [details] [diff] [review]
Fix FHR addon provider test for plugin data count.

Review of attachment 8379964 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #8379964 - Flags: review?(gps) → review+
Followup, this chunk was removed in the comment 4 patch and but dropped when I folded it:
https://hg.mozilla.org/integration/mozilla-inbound/rev/505119ed119e
You need to log in before you can comment on or make changes to this bug.