971447 - [System2] Instantiable ActionMenu

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[(inactive after 6/18) Alive Kuo [:alive]]

We need action_menu.js to be instantiable and let bootstrap or its parent module to instantiate it.
Also jsdoc + unit test wanted.

Comment 1

[Kevin Grandon :kgrandon]

Attachment: Github pull request

Comment 2

[Kevin Grandon :kgrandon]

Comment on attachment 8377286 [details] [review]
Github pull request

Alive - would you have time for a review here? Thanks!

Comment 3

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8377286 [details] [review]
Github pull request

Please implement destroy to remove the DOM elements created by this class, otherwise we will have dead elements in the DOM tree and create new one each time we have an activity request!
(Call destroy on hide.)

Comment 4

[Kevin Grandon :kgrandon]

Comment on attachment 8377286 [details] [review]
Github pull request

Hey Alive - I added a few commits here which fix this a bit. I added start/stop methods to the class which will create/destroy the dom and add/remove listeners.

Consumers of this class would then do something like:

var menu = new ActionMenu(items, title, success);
menu.start();

Trying to follow other system conventions here as well as the start/stop methods in Tim's email. Let me know what you think - I will definitely squash this before merging. Thanks!

Comment 5

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8377286 [details] [review]
Github pull request

Thanks!

Comment 6

[Kevin Grandon :kgrandon]

I want to get this landed before the bug bash today.

Landed in master: https://github.com/mozilla-b2g/gaia/commit/117b06a09a1e15ce19f21eaaf53a7fe187b233d8