Closed
Bug 971452
Opened 11 years ago
Closed 11 years ago
[System2] Instantiable ActivityWindowFactory
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: alive, Assigned: lchang)
References
Details
Attachments
(1 file)
We need activity_window_factory.js to be instantiable and let bootstrap or its parent module to instantiate it.
Also jsdoc improvement + unit test modification wanted.
| Assignee | ||
Updated•11 years ago
|
Assignee: nobody → lchang
| Assignee | ||
Updated•11 years ago
|
Status: NEW → ASSIGNED
| Assignee | ||
Comment 1•11 years ago
|
||
I'm trying to take system-app-v2 bugs. Alive, could you please help to review this one? Thanks a lot.
Attachment #8377040 -
Flags: review?(alive)
| Reporter | ||
Comment 2•11 years ago
|
||
Comment on attachment 8377040 [details] [review]
Pull Request 16356
r+ with nits
Attachment #8377040 -
Flags: review?(alive) → review+
| Assignee | ||
Comment 3•11 years ago
|
||
travis passed:
https://travis-ci.org/mozilla-b2g/gaia/builds/19089679
merged in gaia master:
https://github.com/mozilla-b2g/gaia/commit/686c62482c70aa3dafaaaaab351c5618408ce7ae
Alive, Thanks!
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•