971456 - [Camera][Madai] Visual Design Touch Focus Indicators

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect, P1)

Description

[Amy Lee [:amylee] UX]

User story:

1. As a user, while in camera mode I want auto focus be enabled by touch if the device doesn't support either face tracking or continuous focus
2. As a user, while in video mode I want auto focus be enabled by touch if the device doesn't support either face tracking or continuous focus

Will attach visual specs

Comment 1

[Amy Lee [:amylee] UX]

Attachment: CSS_Pixels_Auto_Touch_Focus_Indicators.jpg

Comment 2

[Amy Lee [:amylee] UX]

Attachment: Focus_Locked_Ring.svg

Focus Locked Ring

Comment 3

[Amy Lee [:amylee] UX]

Attachment: Focus_Locking_Ring.svg

Focus Locking Ring

Comment 4

[Amy Lee [:amylee] UX]

Attachment: Focus_Locking_Ring.svg

Updated indicator

Comment 5

[Amy Lee [:amylee] UX]

Attachment: Focus_Locked_Ring.svg

Updated locked ring

Comment 6

[Amy Lee [:amylee] UX]

Attachment: CSS_Pixels_Auto_Touch_Focus_Video.png

Spec for Auto/Touch Focus in Video Record mode.

Comment 7

[Amy Lee [:amylee] UX]

Attachment: AF_Icon.svg

Auto Focus icon for video mode

Comment 8

[Youngjun Kim]

Prasad! 

Please attach the screenshot of current implementation to be reviewed by Mozilla UX.

And request Amy to review.

Comment 9

[Jyothiprasad]

Attachment: Pointer to pull request

Comment 10

[David Flanagan [:djf]]

Comment on attachment 8385256 [details] [review]
Pointer to pull request

I put review comments on this commit: https://github.com/jyothiprasad/gaia/commit/cef3350f80d4cae7430316a549558a84a08b5304

This is much better, but r- because there are still bugs in findFocusArea().

Is there code in this patch anywhere to reset the focus position to the center? I'd assume that after taking a photo the default foucus area should go back to center, but I haven't seen code to do that.

I also wonder how this is going to work on cameras that support CAF, and think you ought to consider combinging the touch focus and CAF patches into a single patch.  On the other hand, it might be simpler to just get this one landed first.

Also: are there tests in one of the these commits?  I did not see any in what I reviewed.

After addressing the comments, please create a new PR against camera-new-features instead of camera-dev.

Comment 11

[Wayne Chang [:wchang]]

Touch focus is not part of 1.4 now, correcting bug details.

Comment 12

[Hema Koka [:hema]]

Diego, assigning this to you since you have taken over the touch focus feature..you can close this one if we got ux+ already for touch focus work tracked in the other bug

thanks
hema

Comment 13

[Diego Marcos [:dmarcos]]

This one landed as part of https://bugzilla.mozilla.org/show_bug.cgi?id=966830