Closed
Bug 971484
Opened 10 years ago
Closed 10 years ago
[System2] Instantiable DialerComms
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: alive, Assigned: kgrandon)
References
Details
Attachments
(2 files)
We need dailercomms.js to be instantiable and let bootstrap or its parent module to instantiate it. Also jsdoc + unit test improvement wanted. BTW the content of this file makes me sad.
|
Assignee | |
Comment 1•10 years ago
|
||
Hah - this one is a tiny one so I will take it. Agree that the content is sad - so if you want to move it or integrate it somewhere else we can do that.
Assignee: nobody → kgrandon
Summary: [System2] Instantiable DailerComms → [System2] Instantiable DialerComms
|
|
Assignee | |
Comment 2•10 years ago
|
||
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8375679 -
Flags: review?(alive)
|
Reporter | |
Comment 3•10 years ago
|
||
Comment on attachment 8375679 [details] [review] Github pull request r+ with nit
Attachment #8375679 -
Flags: review?(alive) → review+
|
|
Assignee | |
Comment 4•10 years ago
|
||
Landed: https://github.com/mozilla-b2g/gaia/commit/5b751739b25b29a7233938b0743a65a85def3ea4
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 5•10 years ago
|
||
This is the thing where travis is green, and TBPL is not. The tests should probably fail on travis here =/
|
|
Assignee | |
Comment 6•10 years ago
|
||
Comment on attachment 8377399 [details] [review] Pull request - followup Going r=me on this now that the test passes locally and this is an exact copy of the slim mocks we use elsewhere. I'd really like to have a better solution for this in the future though.
Attachment #8377399 -
Flags: review+
|
|
Assignee | |
Comment 7•10 years ago
|
||
Follow-up landed: https://github.com/mozilla-b2g/gaia/commit/96df3ec605075a919794b737306e5af300cf9681
You need to log in
before you can comment on or make changes to this bug.
Description
•