Closed Bug 971486 Opened 10 years ago Closed 10 years ago

[System2] Instantiable EdgeSwipeDetector

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(b2g-v2.1 wontfix, b2g-v2.2 fixed)

RESOLVED FIXED
2.1 S5 (26sep)
Tracking Status
b2g-v2.1 --- wontfix
b2g-v2.2 --- fixed

People

(Reporter: alive, Assigned: kgrandon)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

We need edge_swipe_gesture.js to be instantiable and let bootstrap or its parent module to instantiate it.
Also jsdoc + unit test improvement wanted.
Summary: [System2] Instantiable EdgeSwipeGesture → [System2] Instantiable EdgeSwipeDetector
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
Attached file Github pull request
Comment on attachment 8492846 [details]
Github pull request

Alive - this one is fairly well tested already, so I'm just doing some clean up and bringing it into the new pattern. Please take a look if you have time. Thanks!
Attachment #8492846 - Flags: review?(alive)
Comment on attachment 8492846 [details]
Github pull request

r=me if tested
Attachment #8492846 - Flags: review?(alive) → review+
(In reply to Alive Kuo [:alive][NEEDINFO!] from comment #3)
> Comment on attachment 8492846 [details]
> Github pull request
> 
> r=me if tested

Thanks. Tested on a device and everything seems to continue to work. Landing: https://github.com/mozilla-b2g/gaia/commit/fc44f9912f2cb9f33f1117e30c713121a753b486
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [systemsfe]
Target Milestone: --- → 2.1 S5 (26sep)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: