[System2] Instantiable MediaRecording

RESOLVED FIXED

Status

Firefox OS
Gaia::System
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: alive, Assigned: gasolin@mozilla.com)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

We need media_recording.js to be instantiable and let bootstrap or its parent module to instantiate it.
Also jsdoc + unit test improvement wanted.

Updated

4 years ago
Assignee: nobody → johu
Created attachment 8377498 [details] [review]
PR for this bug

put the PR here and wait for travis's signal.
Comment on attachment 8377498 [details] [review]
PR for this bug

Alive,

Please review this patch. It changes the followings:
1. wraps the MediaRecording as instantiable object
2. remove few useless variables
3. make media_recording.js, media_recording_test.js pass jshint
Attachment #8377498 - Flags: review?(alive)
Comment on attachment 8377498 [details] [review]
PR for this bug

Please fix bootstrap_test.
Attachment #8377498 - Flags: review?(alive)
Comment on attachment 8377498 [details] [review]
PR for this bug

Hi alive,

Please review it again. I had updated the bootstrap_test.js. Thanks.
Attachment #8377498 - Flags: review?(alive)
Attachment #8377498 - Flags: review?(alive) → review+
(Assignee)

Comment 8

4 years ago
backout because conflict with master https://github.com/mozilla-b2g/gaia/commit/7e27508768e45c7d2ce07f7a4314b2774f934c12
Whiteboard: [in-bubble-tea]
Deassign myself.

It's so sad to see this back out. It's not a complex patch but just a wrapper. I may take it back when I am free.
Assignee: johu → nobody
(Assignee)

Comment 10

4 years ago
let me do it after new media_recording merged ;->
Assignee: nobody → gasolin
(Assignee)

Comment 12

4 years ago
all green, will ask for review till bubble-tea merged
(Assignee)

Comment 13

4 years ago
Created attachment 8396967 [details] [review]
pull request redirect to github
(Assignee)

Comment 14

4 years ago
Comment on attachment 8396967 [details] [review]
pull request redirect to github

travis looks good
Attachment #8396967 - Flags: review?(alive)
Attachment #8396967 - Flags: review?(alive) → review+
(Assignee)

Comment 15

4 years ago
fixed addressed issue and merged to gaia-master https://github.com/mozilla-b2g/gaia/commit/2462d4102562ddd06d2dfeeb77c52507239e8292

thanks!
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.