Closed Bug 971515 Opened 12 years ago Closed 12 years ago

[System2] Instantiable MediaRecording

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: alive, Assigned: gasolin)

References

Details

Attachments

(3 files)

PR for this bug
46 bytes, text/x-github-pull-request
alive
: review+
Details | Review
PR for bubble tea
46 bytes, text/x-github-pull-request
Details | Review
pull request redirect to github
46 bytes, text/x-github-pull-request
alive
: review+
Details | Review
We need media_recording.js to be instantiable and let bootstrap or its parent module to instantiate it. Also jsdoc + unit test improvement wanted.
Assignee: nobody → johu
Attached file PR for this bug —
put the PR here and wait for travis's signal.
Comment on attachment 8377498 [details] [review] PR for this bug Alive, Please review this patch. It changes the followings: 1. wraps the MediaRecording as instantiable object 2. remove few useless variables 3. make media_recording.js, media_recording_test.js pass jshint
Attachment #8377498 - Flags: review?(alive)
Comment on attachment 8377498 [details] [review] PR for this bug Please fix bootstrap_test.
Attachment #8377498 - Flags: review?(alive)
Comment on attachment 8377498 [details] [review] PR for this bug Hi alive, Please review it again. I had updated the bootstrap_test.js. Thanks.
Attachment #8377498 - Flags: review?(alive)
Attachment #8377498 - Flags: review?(alive) → review+
backout because conflict with master https://github.com/mozilla-b2g/gaia/commit/7e27508768e45c7d2ce07f7a4314b2774f934c12
Whiteboard: [in-bubble-tea]
Deassign myself. It's so sad to see this back out. It's not a complex patch but just a wrapper. I may take it back when I am free.
Assignee: johu → nobody
let me do it after new media_recording merged ;->
Assignee: nobody → gasolin
all green, will ask for review till bubble-tea merged
Comment on attachment 8396967 [details] [review] pull request redirect to github travis looks good
Attachment #8396967 - Flags: review?(alive)
Attachment #8396967 - Flags: review?(alive) → review+
fixed addressed issue and merged to gaia-master https://github.com/mozilla-b2g/gaia/commit/2462d4102562ddd06d2dfeeb77c52507239e8292 thanks!
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: