971569 - [System2] Instantiable TTLView

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[(inactive after 6/18) Alive Kuo [:alive]]

We need ttl_view.js to be instantiable and let bootstrap or its parent module to instantiate it.
Also jsdoc + unit test improvement wanted.

Comment 1

[Kevin Grandon :kgrandon]

I'll help with some easy ones first, taking this.

Comment 2

[Kevin Grandon :kgrandon]

Attachment: Github pull request

Comment 3

[Kevin Grandon :kgrandon]

Comment on attachment 8374866 [details] [review]
Github pull request

Hey Alive - before taking more work I wanted to make sure I was doing this correctly. Can you take a look and let me know what you think?

I made a few changes to the conventions, and I think we should probably use them, if you're against these, we can discuss them.

1 - No more duplicate named function. We are no longer required to name functions which are members of an object. We were originally doing this for profiling, but platform support has landed which means we no longer have to do this.

2 - Usage of Object.prototype = {} for methods. I personally think that this is much more readable, and will often avoid awkward line breaking. This is the pattern we use in a lot of the other applications as well. In order to register class members, you need to specify @class in the constructor docblock, and /** @lends <ClassName> */ inside of the prototype assignment.

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8374866 [details] [review]
Github pull request

r+ if you wrap ttlview with IIFE. Really appreciated for document + test + jshint fix! Great first system-app-v2 bug.

Comment 5

[Kevin Grandon :kgrandon]

Landed: https://github.com/mozilla-b2g/gaia/commit/cc434ec55e5fc2abc78f96961f5e9d35f10f16a3

Comment 6

[Cédric de Saint Martin]

Attachment: Fix bootstrap test

Comment 7

[Kevin Grandon :kgrandon]

Comment on attachment 8375642 [details] [review]
Fix bootstrap test

Travis is super slow this morning, but I want this for some other patches (will keep an eye on it, but I am sure it's fine).

Landed follow-up: https://github.com/mozilla-b2g/gaia/commit/edb989a286623257d0fb061583ae9cd9a1916732

Comment 8

[Kevin Grandon :kgrandon]

Landed a follow-up (comments only), that fix JSDoc style due to the anon function: https://github.com/mozilla-b2g/gaia/commit/838bd0bf6fb37728952add07bf95bb0370eeb896