Closed Bug 971586 Opened 6 years ago Closed 6 years ago

topsrcdir should be absolute when executing mozconfig2configure

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla30

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file)

When running relative/path/to/configure from an objdir, topsrcdir ends up being "relative/path/to", and for tooltool-using mozconfigs, that means CC is wrong for any directory that is not topobjdir.

relative/path/to/configure is how valgrind builds do their stuff (yes, arguably, they should be using client.mk like everything else, or mach, but i don't feel like waiting for that to happen)
Attachment #8374645 - Flags: review?(gps) → review+
https://hg.mozilla.org/mozilla-central/rev/42ca2046b7e5
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.