971605 - Gaiatest can not restart b2g process on hamachi

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Askeing Yen[:askeing][:fyen]]

## ENV
Gaia      4c6b5142d3b716f1c4ea502eeb92d3119f2b01c6
Gecko     https://hg.mozilla.org/mozilla-central/rev/802d87c77e76
BuildID   20140211160209
Version   30.0a1
ro.build.version.incremental=eng.archermind.20131114.105818
ro.build.date=Thu Nov 14 10:58:33 CST 2013

## Description
the device.is_android_build is False in current build, so gaiatest will skip the code of gaia_test.py#L876~L880.
* restart is True, device.is_android_build is False, m.instance is None
* True and None -> None

Comment 1

[Askeing Yen[:askeing][:fyen]]

### This build cannot restart
Gaia      4c6b5142d3b716f1c4ea502eeb92d3119f2b01c6
Gecko     https://hg.mozilla.org/mozilla-central/rev/802d87c77e76
BuildID   20140211160209
Version   30.0a1
ro.build.version.incremental=eng.archermind.20131114.105818
ro.build.date=Thu Nov 14 10:58:33 CST 2013

>>> from marionette import Marionette
>>> marionette = Marionette('localhost', 2828)
>>> marionette.start_session()
{u'rotatable': True, u'takesElementScreenshot': True, u'takesScreenshot': True, u'appBuildId': u'20140211160209', u'cssSelectorsEnabled': True, u'javascriptEnabled': True, u'XULappId': u'{3c2e2abc-06d4-11e1-ac3b-374f68613e61}', u'secureSsl': False, u'platform': u'ANDROID', u'browserName': u'B2G', u'version': u'30.0a1', u'device': u'msm7627a', u'b2g': True, u'nativeEvents': False, u'platformVersion': u'30.0a1', u'platformName': u'ANDROID', u'handlesAlerts': False}
>>> marionette.session_capabilities['platformName']
u'ANDROID'
>>> 

### This build can restart
Gaia      9fc36dde3a4a3c5ca200275b68ffb56b4173bec3
Gecko     https://hg.mozilla.org/mozilla-central/rev/d812f80a0f1d
BuildID   20140211040200
Version   30.0a1
ro.build.version.incremental=eng.archermind.20131114.105818
ro.build.date=Thu Nov 14 10:58:33 CST 2013

>>> from marionette import Marionette
>>> marionette = Marionette('localhost', 2828)
>>> marionette.start_session()
{u'rotatable': True, u'takesElementScreenshot': True, u'takesScreenshot': True, u'appBuildId': u'20140211040200', u'cssSelectorsEnabled': True, u'javascriptEnabled': True, u'XULappId': u'{3c2e2abc-06d4-11e1-ac3b-374f68613e61}', u'secureSsl': False, u'platform': u'Android', u'browserName': u'B2G', u'version': u'30.0a1', u'device': u'msm7627a', u'b2g': True, u'nativeEvents': False, u'platformVersion': u'30.0a1', u'platformName': u'Android', u'handlesAlerts': False}
>>> marionette.session_capabilities['platformName']
u'Android'
>>> 

It seems like we can fix this issue by modifying the gaia_test.py#L697.

Comment 2

[Askeing Yen[:askeing][:fyen]]

Attachment: PR 16200

Comment 3

[Zac C (:zac)]

Merged!

https://github.com/mozilla-b2g/gaia/commit/0ff3475e555992f630bb0a042537a917d5fd18db

Comment 4

[Askeing Yen[:askeing][:fyen]]

Zac found the source: Bug 964367
> let platformName = Services.appinfo.OS.toUpperCase();

Comment 5

[Walter Chen[:ypwalter][:wachen]]

Hi, v1.3 is suffering from the same bug. Please uplift. T____T

Comment 6

[William Lachance (:wlach)]

(In reply to Walter Chen[:ypwalter][:wachen] from comment #5)
> Hi, v1.3 is suffering from the same bug. Please uplift. T____T

:jgriffin just released a new version of gaiatest to pypi so you should be ok if you pick that up.