Closed
Bug 971659
Opened 12 years ago
Closed 12 years ago
linking error when --disable-webrtc on b2g
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla30
People
(Reporter: slee, Assigned: slee)
Details
Attachments
(1 file, 1 obsolete file)
|
742 bytes,
patch
|
slee
:
review+
|
Details | Diff | Splinter Review |
Pico module depends on WebRTC flag([1]) but when we disable webrtc, configure.in does not disable pico module. So that we will get linking error.
[1] http://dxr.mozilla.org/mozilla-central/source/content/media/webspeech/synth/pico/PicoModule.cpp#8
|
Assignee | |
Comment 1•12 years ago
|
||
Hi Ted,
Could you help review the patch?
Thanks.
Assignee: nobody → slee
Attachment #8374741 -
Flags: review?(ted)
|
||
Updated•12 years ago
|
Attachment #8374741 -
Flags: review?(ted) → review+
|
|
Assignee | |
Comment 2•12 years ago
|
||
Adding reviewer info.
Here is the try server results.
Attachment #8374741 -
Attachment is obsolete: true
Attachment #8375972 -
Flags: review+
|
|
Assignee | |
Updated•12 years ago
|
Keywords: checkin-needed
|
||
Comment 3•12 years ago
|
||
Keywords: checkin-needed
|
||
Comment 4•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•