Closed Bug 971659 Opened 6 years ago Closed 6 years ago

linking error when --disable-webrtc on b2g

Categories

(Firefox Build System :: General, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla30

People

(Reporter: slee, Assigned: slee)

Details

Attachments

(1 file, 1 obsolete file)

Pico module depends on WebRTC flag([1]) but when we disable webrtc, configure.in does not disable pico module. So that we will get linking error.

[1] http://dxr.mozilla.org/mozilla-central/source/content/media/webspeech/synth/pico/PicoModule.cpp#8
Attached patch disable-pico (obsolete) — Splinter Review
Hi Ted,

Could you help review the patch?
Thanks.
Assignee: nobody → slee
Attachment #8374741 - Flags: review?(ted)
Attachment #8374741 - Flags: review?(ted) → review+
Attached patch disable-picoSplinter Review
Adding reviewer info.

Here is the try server results.
Attachment #8374741 - Attachment is obsolete: true
Attachment #8375972 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/4628d3607b3d
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.