971664 - MediaRecorder - Should assert for the threadsafety issue (follow-up bug 957439)

Status: RESOLVED FIXED

(Core :: Audio/Video: Recording, defect)

Description

[Shelly Lin [:shelly]]

Please see bug 957439, comment 31
(Thanks for pointing this out Kyle!)

Assertions are for illegal usages.

The nit fix should be:

MOZ_ASSERT(NS_IsMainThread());
NS_ENSURE_TRUE(mTrackUnionStream, NS_ERROR_FAILURE);

Comment 1

[Shelly Lin [:shelly]]

Attachment: Should assert for threadsafety issue in Pause/Resume

Hi Kyle, would you mind reviewing the fix :)?

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 8378018 [details] [diff] [review]
Should assert for threadsafety issue in Pause/Resume

Review of attachment 8378018 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

ty!

Comment 3

[Shelly Lin [:shelly]]

Attachment: [check-in patch] Should assert for threadsafety issue in Pause/Resume

Thank you!

Carry r+ from :khuey.

Try result:
https://tbpl.mozilla.org/?tree=Try&rev=facbc890e6dc

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/4726ef9d760c

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4726ef9d760c