Closed Bug 971664 Opened 6 years ago Closed 6 years ago

MediaRecorder - Should assert for the threadsafety issue (follow-up bug 957439)

Categories

(Core :: Audio/Video: Recording, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla30

People

(Reporter: shelly, Assigned: shelly)

Details

Attachments

(1 file, 1 obsolete file)

Please see bug 957439, comment 31
(Thanks for pointing this out Kyle!)

Assertions are for illegal usages.

The nit fix should be:

MOZ_ASSERT(NS_IsMainThread());
NS_ENSURE_TRUE(mTrackUnionStream, NS_ERROR_FAILURE);
Hi Kyle, would you mind reviewing the fix :)?
Attachment #8378018 - Flags: review?(khuey)
Comment on attachment 8378018 [details] [diff] [review]
Should assert for threadsafety issue in Pause/Resume

Review of attachment 8378018 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

ty!
Attachment #8378018 - Flags: review?(khuey) → review+
Thank you!

Carry r+ from :khuey.

Try result:
https://tbpl.mozilla.org/?tree=Try&rev=facbc890e6dc
Attachment #8378018 - Attachment is obsolete: true
Attachment #8378057 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/4726ef9d760c
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
Component: Video/Audio → Video/Audio: Recording
No longer blocks: MediaRecording
You need to log in before you can comment on or make changes to this bug.