971735 - java.util.ConcurrentModificationException: at java.util.ArrayList$ArrayListIterator.next(ArrayList.java) in removeHistoricalRecordsForPackage()

Status: RESOLVED FIXED

(Firefox for Android :: General, defect)

Description

[Lucas Rocha (:lucasr)]

83b34bca-ec7a-489e-9d02-b97222140211

java.util.ConcurrentModificationException
	at java.util.ArrayList$ArrayListIterator.next(ArrayList.java:569)
	at org.mozilla.gecko.widget.ActivityChooserModel.access$600(ActivityChooserModel.java:104)
	at org.mozilla.gecko.widget.ActivityChooserModel$DataModelPackageMonitor.onReceive(ActivityChooserModel.java:1218)
	at android.app.LoadedApk$ReceiverDispatcher$Args.run(LoadedApk.java:763)
	at android.os.Handler.handleCallback(Handler.java:725)
	at android.os.Handler.dispatchMessage(Handler.java:92)
	at android.os.Looper.loop(Looper.java:175)
	at android.app.ActivityThread.main(ActivityThread.java:5279)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:511)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1102)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:869)
	at dalvik.system.NativeStart.main(Native Method)

Comment 1

[Lucas Rocha (:lucasr)]

Attachment: Remove element using iterator while looping in ArrayList (r=wesj)

Comment 2

[Lucas Rocha (:lucasr)]

Comment on attachment 8374851 [details] [diff] [review]
Remove element using iterator while looping in ArrayList (r=wesj)

Top crasher in Fx29 and Fx30. Apparently caused by bug 881861.

Comment 4

[Wesley Johnston (:wesj)]

Comment on attachment 8374851 [details] [diff] [review]
Remove element using iterator while looping in ArrayList (r=wesj)

Review of attachment 8374851 [details] [diff] [review]:
-----------------------------------------------------------------

I think you're right. This is simpler. Lets just use it. Flipping the dup around....

Comment 6

[Lucas Rocha (:lucasr)]

https://hg.mozilla.org/integration/fx-team/rev/7273e402c9e6

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/7273e402c9e6

Comment 8

[Wesley Johnston (:wesj)]

Comment on attachment 8374851 [details] [diff] [review]
Remove element using iterator while looping in ArrayList (r=wesj)

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 881861, which I'm also noming for uplift
User impact if declined: Crash
Testing completed (on m-c, etc.): Landed on mc last week.
Risk to taking this patch (and alternatives if risky): This is pretty simple and very low risk. Alternatively here is to not uplift 881861
String or IDL/UUID changes made by this patch: none.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/8035d6585f66

Comment 10

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/releases/mozilla-beta/rev/19a78a94f24c

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g28_v1_3/rev/19a78a94f24c