Closed Bug 971744 Opened 10 years ago Closed 10 years ago

Make CairoTextureClientD3D9 fail during lock rather than GetAsDrawTarget

Categories

(Core :: Graphics: Layers, defect)

Product:
Core
Component:
Graphics: Layers
Platform:
x86_64
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla30

People

(Reporter: nical, Assigned: nical)

Details

Attachments

(1 file)

Move check from GetAsDrawTarget to Lock
2.35 KB, patch
mattwoodrow
: review+
Details | Diff | Splinter Review 
When we know at the time of Lock that we will fail to get access to the underlying texture, it is best to fail there, rather than in GetAsDrawTarget because users of TextureClient are supposed to check the result of Lock. We haven't run into an issue with that yet but it will be more robust if we do the check in Lock.
Assignee: nobody → nical.bugzilla

        Attachment #8374863 -
        Flags: review?(matt.woodrow)

        Attachment #8374863 -
        Flags: review?(matt.woodrow) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/6037c4c58363
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: