971778 - Unbox the Sync datatype selections in Preferences

Status: VERIFIED FIXED

(Firefox :: Sync, defect)

Description

[Ryan Feeley [:rfeeley]]

Currently in Preferences the Sync datatype selections are contained within a white box. They should match our other checkbox lists (like the Tabs pane) and just appear regularly like this:
https://www.dropbox.com/s/vhq6ilehd29dpvx/Desktop%20-%20Preferences%20-%20Sync%20-%20Signed%20In.pdf

Comment 1

[Steven MacLeod [:smacleod]]

Attachment: Patch - Remove the richlistbox from the sync datatype selection

Try: https://tbpl.mozilla.org/?tree=Try&rev=61efa6b6c369

Comment 2

[Steven MacLeod [:smacleod]]

Attachment: screenshot.png

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 8384418 [details] [diff] [review]
Patch - Remove the richlistbox from the sync datatype selection

Review of attachment 8384418 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

::: browser/components/preferences/sync.xul
@@ +276,5 @@
> +                        accesskey="&engine.history.accesskey;"
> +                        preference="engine.history"/>
> +              <checkbox label="&engine.tabs.label;"
> +                        accesskey="&engine.tabs.accesskey;"
> +                        preference="engine.tabs"/>

This still has the old ordering, but you'll notice when rebasing ;)

Comment 4

[Steven MacLeod [:smacleod]]

Comment on attachment 8384418 [details] [diff] [review]
Patch - Remove the richlistbox from the sync datatype selection

[Approval Request Comment]
Bug caused by (feature/regressing bug #): feature
User impact if declined: Incorrect styling of Sync preferences
Testing completed (on m-c, etc.): Try push, local build
Risk to taking this patch (and alternatives if risky): Low risk, mostly a cosmetic markup change
String or IDL/UUID changes made by this patch: None

Comment 5

[Steven MacLeod [:smacleod]]

https://hg.mozilla.org/integration/fx-team/rev/a31db792093f

Comment 6

[Steven MacLeod [:smacleod]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/8fcb138f311b

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a31db792093f