971825 - "Undo" link after restoring defaults should be a button

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Dão Gottwald [:dao]]

Reasoning in bug 970511 comment 18.

(In reply to Jared Wein [:jaws] from comment #19)
> It's consistency with the New Tab Page thumbnails.

That's not reason enough for this to be a link. For one, as I've explained, there are places where we've randomly used links instead of buttons for no reason, and we don't want new UI to be consistent with a mess we've created elsewhere. Secondly, there may actually be a valid reason for the New Tab page to use a link, like the fact that it's inside a box along with the "Tumbnail removed" text where a button may look strange, but that reason won't necessarily translate to about:customizing.

Comment 1

[Dão Gottwald [:dao]]

Jared, please take care of this by either making Undo a button or confirming that there's a good reason for it to be a link besides consistency with other unrelated UI. Thanks.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Screenshot with Undo button

Stephen, this is what it would look like with a button instead of the Undo link. What do you think?

Comment 3

[Stephen Horlander [:shorlander]]

I agree that a button is the proper affordance to use here. 

We could have a whole debate about the use of links for secondary commands or for things with minor consequences, but this probably isn't the place ;)

Thanks!

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/integration/fx-team/rev/8e9dfd4baac1

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8375673 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): change in design req. for bug 970511
User impact if declined: change in design between 29 and 30
Testing completed (on m-c, etc.): local, simple change
Risk to taking this patch (and alternatives if risky): none
String or IDL/UUID changes made by this patch: none

Comment 7

[Sylvestre Ledru [:Sylvestre]]

I will approve it once it reached m-c.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8e9dfd4baac1

Comment 9

[:Gijs (he/him)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c9996aa6bdae

Comment 10

[Cornel Ionce [:noni]]

Verified as fixed on Windows 7 64 bit, Ubuntu 12.04 and Mac OS X 10.9 using latest Nightly (build ID: 20140313030202) and latest Aurora (build ID: 20140313004000). 
"Undo" is now displayed as a button instead of a link.