971831 - get rid of RangeBoundToHypertextOffset

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

just replace calls by its content, see http://mxr.mozilla.org/mozilla-central/ident?i=RangeBoundToHypertextOffset&filter=

Comment 1

[Peiyong Lin[:lpy](UTC+8)]

Attachment: bug971831.patch

Comment 2

[alexander :surkov (:asurkov)]

Comment on attachment 8375379 [details] [diff] [review]
bug971831.patch

Review of attachment 8375379 [details] [diff] [review]:
-----------------------------------------------------------------

pls remove RangeBoundToHypertextOffset method

::: accessible/src/generic/HyperTextAccessible.cpp
@@ +1864,5 @@
>    // the point is not in a range, that we do not need to compute an end offset,
>    // and that we should use the end offset of the last range to compute the
>    // start offset of the text attribute range.
> +  startHTOffset = DOMPointToOffset(domSel->GetRangeAt(rangeCount - 1)->GetEndParent(),
> +                                       domSel->GetRangeAt(rangeCount - 1)->EndOffset());

it'd be nicer to have local variable for range
nit: fix second line indentation

Comment 3

[Peiyong Lin[:lpy](UTC+8)]

Attachment: bug971831-V2.patch

thanks

Comment 4

[alexander :surkov (:asurkov)]

Comment on attachment 8375485 [details] [diff] [review]
bug971831-V2.patch

Review of attachment 8375485 [details] [diff] [review]:
-----------------------------------------------------------------

r=me thx! please fix nits, attach new patch and add checking-needed keyword

::: accessible/src/generic/HyperTextAccessible.cpp
@@ +1826,3 @@
>  
>      if (idx > 0) {
> +      nsRange* domSelRange = domSel->GetRangeAt(idx - 1);

nit: pls rename it to prevRange

@@ +1842,5 @@
>    // We never found a range that ended after the point, therefore we know that
>    // the point is not in a range, that we do not need to compute an end offset,
>    // and that we should use the end offset of the last range to compute the
>    // start offset of the text attribute range.
> +  nsRange* domSelRange = domSel->GetRangeAt(rangeCount - 1);

same

Comment 5

[Peiyong Lin[:lpy](UTC+8)]

Attachment: bug971831-V3.patch

thanks

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/93ce1741b01b

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/93ce1741b01b