Closed Bug 97185 Opened 22 years ago Closed 22 years ago
_select should add a newline after each option
In CGI.pl, there is a nice function called make_select. This nice function, however, doesn't add a newline to each option, making it quite impossible to see the options listed nicely in a view source window (or in any dump for that matter). It's quite easy to add a "\n" to each option, and it would only increase page size by a few bytes.
This patch, if applied, would cause redhat's query.cgi to grow by less than 1.7K. It would also cause bmo query.cgi to grow by less than 0.5K. I find that very acceptable against the improved readability of the code. It looses that "oh, this was generated by a script" feeling, too.
Status: NEW → ASSIGNED
over to me
Assignee: justdave → kiko
Status: ASSIGNED → NEW
Comment on attachment 47255 [details] [diff] [review] Adds \n to OPTION output in CGI.pl firstname.lastname@example.org if the print $msg; line is removed from this patch. 2nd review approval required for this to make sure we really want it
Attachment #47255 - Flags: review+
Comment on attachment 52669 [details] [diff] [review] kiko_v2: removed $msg duh r=gerv. No reason why we shouldn't do this, given that each line is already 30+ characters. Gerv
Attachment #52669 - Flags: review+
/cvsroot/mozilla/webtools/bugzilla/CGI.pl,v <-- CGI.pl new revision: 1.106; previous revision: 1.105
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Fixed for 2.16
no, really this time :)
Target Milestone: --- → Bugzilla 2.16
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.