97185 - make_select should add a newline after each option

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect)

Description

[Christian Reis]

In CGI.pl, there is a nice function called make_select. This nice function,
however, doesn't add a newline to each option, making it quite impossible to see
the options listed nicely in a view source window (or in any dump for that
matter). It's quite easy to add a "\n" to each option, and it would only
increase page size by a few bytes.

Comment 1

[Christian Reis]

Attachment: Adds \n to OPTION output in CGI.pl

Comment 2

[Christian Reis]

This patch, if applied, would cause redhat's query.cgi to grow by less than
1.7K. It would also cause bmo query.cgi to grow by less than 0.5K. I find that
very acceptable against the improved readability of the code. It looses that
"oh, this was generated by a script" feeling, too.

Comment 3

[Christian Reis]

over to me

Comment 4

[Zach Lipton [:zach]]

Comment on attachment 47255 [details] [diff] [review]
Adds \n to OPTION output in CGI.pl

r=[e-mail] if the print $msg; line is removed from this patch. 2nd review approval required for this to make sure we really want it

Comment 5

[Christian Reis]

Attachment: kiko_v2: removed $msg duh

Comment 6

[Gervase Markham [:gerv]]

Comment on attachment 52669 [details] [diff] [review]
kiko_v2: removed $msg duh

r=gerv. No reason why we shouldn't do this, given that each line is already 30+ characters.

Gerv

Comment 7

[timeless]

/cvsroot/mozilla/webtools/bugzilla/CGI.pl,v  <--  CGI.pl
new revision: 1.106; previous revision: 1.105

Comment 8

[Dave Miller [:justdave]]

Fixed for 2.16

Comment 9

[Dave Miller [:justdave]]

no, really this time :)