Closed Bug 971991 Opened 10 years ago Closed 10 years ago

Loop Server needs to accept FxA bid assertion and simple push URL

Categories

(Hello (Loop) :: Server, defect)

Product:
Hello (Loop)
Component:
Server
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: abr, Assigned: alexis+bugs)

References

Details

User Story

This is the service that accepts registrations of simple push URLs for a user.
      No description provided.
Blocks: loop_mvp
Component: General → Client
Component: Client → Server
This is the service that accepts registrations of simple push URLs for a user.
Summary: Server needs to accept auth token and simple push URL → MEET Server needs to accept auth token and simple push URL
I think we should associate userids with push urls (eventually multiple ones) and not auth tokens. Auth tokens issued by the tokenserver will eventually expire whereas the userid will not.

Associating the simple push url with an user id allows us to have a persistant way to find back how to contact our users.
That's consistent with my understanding of the plan.
Blocks: loop_mlp
For MLP, I bet we want to do whatever's easiest.  I've heard use cases for both expiring and non-expiring URLs.  Which of these gets prioritized for MVP is presumably up to product.
For non-expiring, it becomes a lot more important to tackle revocation early on, which is I think a harder problem than an expiry.
(In reply to Dan Mosedale (:dmose) from comment #5)
> For MLP, I bet we want to do whatever's easiest.  I've heard use cases for
> both expiring and non-expiring URLs.  Which of these gets prioritized for
> MVP is presumably up to product.

Which URLs are you talking about here? The Simple Push Server URLs?
abr: good catch; I was in fact confused. Please disregard my comment.  :-)
User Story: (updated)
Summary: MEET Server needs to accept auth token and simple push URL → Loop Server needs to accept auth token and simple push URL
Bug 972020 states we don't need integration with the token server for the MLP.
Summary: Loop Server needs to accept auth token and simple push URL → Loop Server needs to accept FxA auth token and simple push URL
Assignee: nobody → alexis+bugs
We need to accept browserid assertions directly, and not tokens issued by the token server. Eventually, to avoid having to do a bid verification on the server each time, we can put a session cookie on the client then.
Summary: Loop Server needs to accept FxA auth token and simple push URL → Loop Server needs to accept FxA bid assertion and simple push URL
For clarity, this is for the step that associates an FxA account ID with a simple push URL.
https://github.com/mozilla/loop-server/commit/a9aa6d1442624ba2014f42d6f9230ce3d1b2226f
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
:alexis
I guess this is moot since loop/authentication.js is no longer part of the repo?
It's still the case but doesn't happen the same way. Have a look at loop/fxa.js and loop/index.js for more insights on how this is working.
Yep. That's fine.
Status: RESOLVED → VERIFIED
QA Contact: jbonacci
You need to log in before you can comment on or make changes to this bug.