972051 - Dismiss "Tap to sign in" notification when a sync succeeds

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Android Sync, defect, P1)

Comment 1

[Nick Alexander :nalexander [he/him]]

Attachment: github PR

Builds on other tickets (although I don't expect there to be a real dependency), so review in order.

Comment 2

[Nick Alexander :nalexander [he/him]]

https://bugzilla.mozilla.org/show_bug.cgi?id=972051

Comment 3

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/integration/fx-team/rev/17f17341aa01

Comment 4

[Nick Alexander :nalexander [he/him]]

Attachment: 17f17341aa01

[Approval Request Comment]

This is a good candidate for uplift.  It needs to bake for a few days, but we know we want it, and it would be nice to uplift just to m-a rather than all the way to m-b, so opening the approval request early.

Bug caused by (feature/regressing bug #): initial FxA landing.

User impact if declined: annoying notifications persist.

Testing completed (on m-c, etc.): Tested locally.  Needs to bake for a few days.

Risk to taking this patch (and alternatives if risky): very low.

String or IDL/UUID changes made by this patch: none.

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/17f17341aa01

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8384953 [details]
17f17341aa01

Baked for 3 days. I guess that is now enough!

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/55b35360ee1d