Dismiss "Tap to sign in" notification when a sync succeeds

VERIFIED FIXED

Status

()

defect
P1
normal
VERIFIED FIXED
6 years ago
2 years ago

People

(Reporter: rnewman, Assigned: nalexander)

Tracking

(Blocks 1 bug, {polish})

Firefox 29
All
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox29 fixed, firefox30 verified, fennec29+)

Details

(Whiteboard: [qa+][parallel])

Attachments

(2 attachments)

No description provided.
Whiteboard: [qa+][parallel]
Assignee: nobody → nalexander
Priority: -- → P1
Posted file github PR
Builds on other tickets (although I don't expect there to be a real dependency), so review in order.
Attachment #8383265 - Flags: review?(rnewman)
Attachment #8383265 - Flags: review?(rnewman) → review+
Posted file 17f17341aa01
[Approval Request Comment]

This is a good candidate for uplift.  It needs to bake for a few days, but we know we want it, and it would be nice to uplift just to m-a rather than all the way to m-b, so opening the approval request early.

Bug caused by (feature/regressing bug #): initial FxA landing.

User impact if declined: annoying notifications persist.

Testing completed (on m-c, etc.): Tested locally.  Needs to bake for a few days.

Risk to taking this patch (and alternatives if risky): very low.

String or IDL/UUID changes made by this patch: none.
Attachment #8384953 - Flags: review+
Attachment #8384953 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/17f17341aa01
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
Comment on attachment 8384953 [details]
17f17341aa01

Baked for 3 days. I guess that is now enough!
Attachment #8384953 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Product: Android Background Services → Firefox for Android
You need to log in before you can comment on or make changes to this bug.